runtime/vm/stub_code_x64.cc - Issue 1998263002: Include multiplication in the megamorphic cache hash to avoid cid ranges overlapping modulo table s…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_x64.cc

Issue 1998263002: Include multiplication in the megamorphic cache hash to avoid cid ranges overlapping modulo table s… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stub_code_x64.cc

diff --git a/runtime/vm/stub_code_x64.cc b/runtime/vm/stub_code_x64.cc

index 4e8f0e0ded608792f9bd521e8f4d5e61804e5ef2..d66c1254bc9868da34ed2e28aa75ca95f71e6096 100644

--- a/runtime/vm/stub_code_x64.cc

+++ b/runtime/vm/stub_code_x64.cc

@@ -2092,6 +2092,7 @@ void StubCode::EmitMegamorphicLookup(Assembler* assembler) {

// RDI: cache buckets array.

// RBX: mask.

__ movq(RCX, RAX);

+ __ imulq(RCX, Immediate(MegamorphicCache::kSpreadFactor));

Label loop, update, load_target_function;

__ jmp(&loop);

« no previous file with comments | « runtime/vm/stub_code_mips.cc ('k') | no next file » | no next file with comments »