runtime/vm/object.cc - Issue 1998263002: Include multiplication in the megamorphic cache hash to avoid cid ranges overlapping modulo table s…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 1998263002: Include multiplication in the megamorphic cache hash to avoid cid ranges overlapping modulo table s… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index a8ccce53d8d8ff0a333b3058698b40d2154fd827..241902791c71b507dd4ac524f52ff55352c1933e 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -14735,7 +14735,7 @@ void MegamorphicCache::Insert(const Smi& class_id,

(kLoadFactor * static_cast<double>(mask() + 1)));

const Array& backing_array = Array::Handle(buckets());

intptr_t id_mask = mask();

- intptr_t index = class_id.Value() & id_mask;

+ intptr_t index = (class_id.Value() * kSpreadFactor) & id_mask;

intptr_t i = index;

do {

if (Smi::Value(Smi::RawCast(GetClassId(backing_array, i))) == kIllegalCid) {

« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/stub_code_arm.cc » ('j') | no next file with comments »