Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1997863002: Revert of Avoids the "re-encode HPACK as SPDY3" step. (Closed)

Created:
4 years, 7 months ago by Ryan Hamilton
Modified:
4 years, 7 months ago
Reviewers:
dahollings
CC:
chromium-reviews, cbentzel+watch_chromium.org, Buck, Biren Roy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Avoids the "re-encode HPACK as SPDY3" step. (patchset #11 id:260001 of https://codereview.chromium.org/1961573002/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=613079#c4 Seems to break gmail :( Original issue's description: > Avoids the "re-encode HPACK as SPDY3" step. > > This change causes header data to be propagated from SpdyFramer to the > visitor as logical key/value pairs. This avoids the "re-encode HPACK as > SPDY3" step, and therefore should improve performance. > > Now with QUIC support! > > This CL lands server change 120879191 by birenroy. > > BUG=488484 > > Committed: https://crrev.com/600f0c57e92bfbd0e27f889d00d4f3089c464077 > Cr-Commit-Position: refs/heads/master@{#394445} TBR=dahollings@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=488484 Committed: https://crrev.com/3594feaff9f7cadfcaca9d09aa5ef79daa86552b Cr-Commit-Position: refs/heads/master@{#394889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -543 lines) Patch
M net/net.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/quic_chromium_client_stream.h View 1 chunk +0 lines, -6 lines 0 comments Download
M net/quic/quic_chromium_client_stream.cc View 2 chunks +0 lines, -31 lines 0 comments Download
M net/quic/quic_headers_stream.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 11 chunks +30 lines, -46 lines 0 comments Download
M net/quic/quic_spdy_stream.h View 2 chunks +0 lines, -5 lines 0 comments Download
M net/quic/quic_spdy_stream.cc View 3 chunks +2 lines, -12 lines 0 comments Download
M net/quic/quic_spdy_stream_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/spdy_utils.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/spdy_utils_test.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M net/quic/test_tools/mock_quic_spdy_client_stream.h View 1 chunk +1 line, -4 lines 0 comments Download
M net/spdy/buffered_spdy_framer.h View 3 chunks +14 lines, -3 lines 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 2 chunks +2 lines, -41 lines 0 comments Download
M net/spdy/buffered_spdy_framer_unittest.cc View 1 chunk +10 lines, -0 lines 0 comments Download
D net/spdy/header_coalescer.h View 1 chunk +0 lines, -34 lines 0 comments Download
D net/spdy/header_coalescer.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M net/spdy/mock_spdy_framer_visitor.h View 2 chunks +0 lines, -26 lines 0 comments Download
M net/spdy/mock_spdy_framer_visitor.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/spdy/spdy_framer.h View 5 chunks +3 lines, -9 lines 0 comments Download
M net/spdy/spdy_framer.cc View 7 chunks +14 lines, -40 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 25 chunks +93 lines, -224 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session.h View 3 chunks +4 lines, -2 lines 0 comments Download
M net/spdy/spdy_session.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/tools/flip_server/spdy_interface.h View 1 chunk +14 lines, -0 lines 0 comments Download
M net/tools/flip_server/spdy_interface.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.h View 1 chunk +1 line, -3 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Ryan Hamilton
Created Revert of Avoids the "re-encode HPACK as SPDY3" step.
4 years, 7 months ago (2016-05-19 21:11:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997863002/1
4 years, 7 months ago (2016-05-19 21:12:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997863002/1
4 years, 7 months ago (2016-05-19 21:32:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997863002/1
4 years, 7 months ago (2016-05-19 21:43:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997863002/1
4 years, 7 months ago (2016-05-19 22:02:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997863002/1
4 years, 7 months ago (2016-05-19 22:30:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997863002/1
4 years, 7 months ago (2016-05-19 22:32:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 22:38:55 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3594feaff9f7cadfcaca9d09aa5ef79daa86552b Cr-Commit-Position: refs/heads/master@{#394889}
4 years, 7 months ago (2016-05-19 22:40:05 UTC) #11
dahollings
4 years, 7 months ago (2016-05-25 15:45:42 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2013723003/ by dahollings@chromium.org.

The reason for reverting is: Reverting the revert because the bug has been fixed
(https://codereview.chromium.org/2009623002/ -- latent in a dependency of the
reverted code)..

Powered by Google App Engine
This is Rietveld 408576698