Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2162)

Unified Diff: net/spdy/buffered_spdy_framer.h

Issue 1997863002: Revert of Avoids the "re-encode HPACK as SPDY3" step. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/mock_quic_spdy_client_stream.h ('k') | net/spdy/buffered_spdy_framer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/buffered_spdy_framer.h
diff --git a/net/spdy/buffered_spdy_framer.h b/net/spdy/buffered_spdy_framer.h
index 8cc7bce002aa1d4d4b5ce9ee1ca1048986ed6efc..87283b0f6f1abdbddbd4abb9dab6d224f8f5598b 100644
--- a/net/spdy/buffered_spdy_framer.h
+++ b/net/spdy/buffered_spdy_framer.h
@@ -14,7 +14,6 @@
#include "base/macros.h"
#include "net/base/net_export.h"
#include "net/socket/next_proto.h"
-#include "net/spdy/header_coalescer.h"
#include "net/spdy/spdy_framer.h"
#include "net/spdy/spdy_header_block.h"
#include "net/spdy/spdy_protocol.h"
@@ -81,6 +80,20 @@
// |stream_id| The stream receiving data.
// |len| The number of padding octets.
virtual void OnStreamPadding(SpdyStreamId stream_id, size_t len) = 0;
+
+ // Called just before processing the payload of a frame containing header
+ // data. Should return an implementation of SpdyHeadersHandlerInterface that
+ // will receive headers for stream |stream_id|. The caller will not take
+ // ownership of the headers handler. The same instance should be returned
+ // for all header frames comprising a logical header block (i.e. until
+ // OnHeaderFrameEnd() is called with end_headers == true).
+ virtual SpdyHeadersHandlerInterface* OnHeaderFrameStart(
+ SpdyStreamId stream_id) = 0;
+
+ // Called after processing the payload of a frame containing header data.
+ // |end_headers| is true if there will not be any subsequent CONTINUATION
+ // frames.
+ virtual void OnHeaderFrameEnd(SpdyStreamId stream_id, bool end_headers) = 0;
// Called when a SETTINGS frame is received.
// |clear_persisted| True if the respective flag is set on the SETTINGS frame.
@@ -298,8 +311,6 @@
};
std::unique_ptr<GoAwayFields> goaway_fields_;
- std::unique_ptr<HeaderCoalescer> coalescer_;
-
DISALLOW_COPY_AND_ASSIGN(BufferedSpdyFramer);
};
« no previous file with comments | « net/quic/test_tools/mock_quic_spdy_client_stream.h ('k') | net/spdy/buffered_spdy_framer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698