Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: net/quic/spdy_utils.cc

Issue 1997863002: Revert of Avoids the "re-encode HPACK as SPDY3" step. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_spdy_stream_test.cc ('k') | net/quic/spdy_utils_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/spdy_utils.cc
diff --git a/net/quic/spdy_utils.cc b/net/quic/spdy_utils.cc
index bf50d7d29e1bf45cab6306084a8d4a22255d1fe0..90e65373827dc08b0052c52e8e019117d7f82813 100644
--- a/net/quic/spdy_utils.cc
+++ b/net/quic/spdy_utils.cc
@@ -117,6 +117,12 @@
const string& name = p.first;
if (name.empty()) {
DVLOG(1) << "Header name must not be empty.";
+ return false;
+ }
+
+ if (std::any_of(name.begin(), name.end(), base::IsAsciiUpper<char>)) {
+ DLOG(ERROR) << "Malformed header: Header name " << name
+ << " contains upper-case characters.";
return false;
}
« no previous file with comments | « net/quic/quic_spdy_stream_test.cc ('k') | net/quic/spdy_utils_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698