Swallow exceptions from running Chrome's uninstaller in RunCleanCommand.

Swallow exceptions from running Chrome's uninstaller in RunCleanCommand.

This should allow the test to proceed even if a previous install is so
badly broken that the uninstaller crashes or fails.

BUG=611350
Committed: https://crrev.com/6bd57c57b09b844151860758753bf0fb5075e676
Cr-Commit-Position: refs/heads/master@{#395244}

[grt (UTC plus 2), 2016-05-21 01:22:54]

grt@chromium.org changed reviewers:
+ csharp@chromium.org, robertshield@chromium.org

[grt (UTC plus 2), 2016-05-21 01:22:55]

csharp: Python readability review
robertshield: OWNERS review for old time's sake!

[grt (UTC plus 2), 2016-05-21 01:23:38]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-21 01:23:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1997173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1997173002/1

[commit-bot: I haz the power, 2016-05-21 03:14:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-21 03:14:33]

Dry run: This issue passed the CQ dry run.

[robertshield, 2016-05-21 03:20:07]

lgtm

[robertshield, 2016-05-21 03:21:50]

The CQ bit was checked by robertshield@chromium.org

[commit-bot: I haz the power, 2016-05-21 03:22:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1997173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1997173002/1

[commit-bot: I haz the power, 2016-05-21 03:26:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-21 03:28:06]

Description was changed from

==========
Swallow exceptions from running Chrome's uninstaller in RunCleanCommand.

This should allow the test to proceed even if a previous install is so
badly broken that the uninstaller crashes or fails.

BUG=611350
==========

to

==========
Swallow exceptions from running Chrome's uninstaller in RunCleanCommand.

This should allow the test to proceed even if a previous install is so
badly broken that the uninstaller crashes or fails.

BUG=611350

Committed: https://crrev.com/6bd57c57b09b844151860758753bf0fb5075e676
Cr-Commit-Position: refs/heads/master@{#395244}
==========

[commit-bot: I haz the power, 2016-05-21 03:28:08]

Patchset 1 (id:??) landed as
https://crrev.com/6bd57c57b09b844151860758753bf0fb5075e676
Cr-Commit-Position: refs/heads/master@{#395244}

[csharp, 2016-05-24 14:56:04]

https://codereview.chromium.org/1997173002/diff/1/chrome/test/mini_installer/...
File chrome/test/mini_installer/test_installer.py (right):

https://codereview.chromium.org/1997173002/diff/1/chrome/test/mini_installer/...
chrome/test/mini_installer/test_installer.py:222: except:
Is it possible to be more specific about what you are catching here? The style
guide really doesn't like catch all except statement (since they catch
everything, even misspelt names).

If you can't make this a more precise catch, could you add a comment explaining
why you need to catch everything here?