Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: chrome/test/mini_installer/test_installer.py

Issue 1997173002: Swallow exceptions from running Chrome's uninstaller in RunCleanCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/mini_installer/test_installer.py
diff --git a/chrome/test/mini_installer/test_installer.py b/chrome/test/mini_installer/test_installer.py
index 723459b28a9d3e00dd1eaa4d6d91c62a03950127..f038757ac2fd3aa61f277cff605fb9379e6a570d 100644
--- a/chrome/test/mini_installer/test_installer.py
+++ b/chrome/test/mini_installer/test_installer.py
@@ -17,6 +17,7 @@ import os
import subprocess
import sys
import time
+import traceback
import unittest
import _winreg
@@ -216,7 +217,12 @@ def RunCleanCommand(force_clean, variable_expander):
'--chrome-long-name="%s" '
'--no-error-if-absent %s %s' %
(product_name, product_switch, interactive_option))
- RunCommand(command, variable_expander)
+ try:
+ RunCommand(command, variable_expander)
+ except:
csharp 2016/05/24 14:56:04 Is it possible to be more specific about what you
+ message = traceback.format_exception(*sys.exc_info())
+ message.insert(0, 'Error cleaning up an old install with:\n')
+ LogMessage(''.join(message))
if force_clean:
DeleteGoogleUpdateRegistration(system_level, registry_subkey,
variable_expander)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698