Swallow exceptions from running Chrome's uninstaller in RunCleanCommand.

chrome/test/mini_installer/test_installer.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """This script tests the installer with test cases specified in the config file.
 
 For each test case, it checks that the machine states after the execution of
 each command match the expected machine states. For more details, take a look at
 the design documentation at http://goo.gl/Q0rGM6
 """
 
 import argparse
 import datetime
 import inspect
 import json
 import os
 import subprocess
 import sys
 import time
+import traceback
 import unittest
 import _winreg
 
 from variable_expander import VariableExpander
 import verifier_runner
 
 
 def LogMessage(message):
   """Logs a message to stderr.
 
@@ skipping 179 matching lines @@
   if variable_expander.Expand('$SUPPORTS_SXS') == 'True':
     data.append((False, '$CHROME_LONG_NAME_SXS', '',
                  '$CHROME_UPDATE_REGISTRY_SUBKEY_SXS'))
 
   interactive_option = '--interactive' if not force_clean else ''
   for system_level, product_name, product_switch, registry_subkey in data:
     command = ('python uninstall_chrome.py '
                '--chrome-long-name="%s" '
                '--no-error-if-absent %s %s' %
                (product_name, product_switch, interactive_option))
-    RunCommand(command, variable_expander)
+    try:
+      RunCommand(command, variable_expander)
+    except:

[csharp, 2016/05/24 14:56:04]

Is it possible to be more specific about what you are catching here? The style
guide really doesn't like catch all except statement (since they catch
everything, even misspelt names).

If you can't make this a more precise catch, could you add a comment explaining
why you need to catch everything here?

+      message = traceback.format_exception(*sys.exc_info())
+      message.insert(0, 'Error cleaning up an old install with:\n')
+      LogMessage(''.join(message))
     if force_clean:
       DeleteGoogleUpdateRegistration(system_level, registry_subkey,
                                      variable_expander)
 
 
 def MergePropertyDictionaries(current_property, new_property):
   """Merges the new property dictionary into the current property dictionary.
 
   This is different from general dictionary merging in that, in case there are
   keys with the same name, we merge values together in the first level, and we
@@ skipping 203 matching lines @@
     trie[path] = value
     return
   directory, rest = path.split(TEST_SEPARATOR, 1)
   if directory not in trie:
     trie[directory] = {}
   _AddPathToTrie(trie[directory], rest, value)
 
 
 if __name__ == '__main__':
   sys.exit(main())