Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/logging.cc

Issue 1997153002: libchrome: Several upstreamable fixes from libchrome Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: Also fix unit tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/lazy_instance.h ('K') | « base/lazy_instance.h ('k') | base/memory/ref_counted.h » ('j') | base/memory/ref_counted.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/logging.cc
diff --git a/base/logging.cc b/base/logging.cc
index 4390d8cda3069f2c63f7dbd83b97765658773e5c..d1405ff2ea879cc61aaebb744ee0913ce4ac0cad 100644
--- a/base/logging.cc
+++ b/base/logging.cc
@@ -205,7 +205,8 @@ class LoggingLock {
UnlockLogging();
}
- static void Init(LogLockingState lock_log, const PathChar* new_log_file) {
+ static void Init(LogLockingState lock_log,
+ const PathChar* /* new_log_file */) {
if (initialized)
return;
lock_log_file = lock_log;
@@ -455,7 +456,7 @@ template std::string* MakeCheckOpString<std::string, std::string>(
const std::string&, const std::string&, const char* name);
template <>
-void MakeCheckOpValueString(std::ostream* os, const std::nullptr_t& p) {
+void MakeCheckOpValueString(std::ostream* os, const std::nullptr_t& /* p */) {
danakj 2016/05/23 02:59:54 delete the name, it adds nothing
Luis Héctor Chávez 2016/05/24 15:27:53 Done.
(*os) << "nullptr";
}
« base/lazy_instance.h ('K') | « base/lazy_instance.h ('k') | base/memory/ref_counted.h » ('j') | base/memory/ref_counted.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698