Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/memory/ref_counted.h

Issue 1997153002: libchrome: Several upstreamable fixes from libchrome Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: Also fix unit tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/logging.cc ('K') | « base/logging.cc ('k') | base/memory/shared_memory_android.cc » ('j') | base/memory/shared_memory_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/ref_counted.h
diff --git a/base/memory/ref_counted.h b/base/memory/ref_counted.h
index 5b866d14c812fc9645a0ef8285c0369ba93301ac..2b69aaeb0fd4d2696cb7526e7e1ec9f2c4b592a4 100644
--- a/base/memory/ref_counted.h
+++ b/base/memory/ref_counted.h
@@ -425,12 +425,12 @@ bool operator==(const T* lhs, const scoped_refptr<U>& rhs) {
}
template <typename T>
-bool operator==(const scoped_refptr<T>& lhs, std::nullptr_t null) {
+bool operator==(const scoped_refptr<T>& lhs, std::nullptr_t /* null */) {
danakj 2016/05/23 02:59:54 delete the name
Luis Héctor Chávez 2016/05/24 15:27:53 Done.
return !static_cast<bool>(lhs);
}
template <typename T>
-bool operator==(std::nullptr_t null, const scoped_refptr<T>& rhs) {
+bool operator==(std::nullptr_t /* null */, const scoped_refptr<T>& rhs) {
danakj 2016/05/23 02:59:54 delete
Luis Héctor Chávez 2016/05/24 15:27:53 Done.
return !static_cast<bool>(rhs);
}
« base/logging.cc ('K') | « base/logging.cc ('k') | base/memory/shared_memory_android.cc » ('j') | base/memory/shared_memory_android.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698