Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/lazy_instance.h

Issue 1997153002: libchrome: Several upstreamable fixes from libchrome Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: Also fix unit tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/files/file_util_posix.cc ('K') | « base/files/file_util_posix.cc ('k') | base/logging.cc » ('j') | base/logging.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/lazy_instance.h
diff --git a/base/lazy_instance.h b/base/lazy_instance.h
index fd0321017df8f8ba6643f1326db2db581fd05ed5..c030b5b4d636bad5b0a5b72806d70e3061974fdf 100644
--- a/base/lazy_instance.h
+++ b/base/lazy_instance.h
@@ -97,8 +97,7 @@ struct LeakyLazyInstanceTraits {
ANNOTATE_SCOPED_MEMORY_LEAK;
return DefaultLazyInstanceTraits<Type>::New(instance);
}
- static void Delete(Type* instance) {
- }
+ static void Delete(Type* /* instance */) {}
danakj 2016/05/23 02:59:54 delete the name, it adds no value
Luis Héctor Chávez 2016/05/24 15:27:53 Done.
};
// Our AtomicWord doubles as a spinlock, where a value of
« base/files/file_util_posix.cc ('K') | « base/files/file_util_posix.cc ('k') | base/logging.cc » ('j') | base/logging.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698