Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3862)

Unified Diff: base/files/file_util_posix.cc

Issue 1997153002: libchrome: Several upstreamable fixes from libchrome Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: Also fix unit tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/files/file_util_posix.cc
diff --git a/base/files/file_util_posix.cc b/base/files/file_util_posix.cc
index ca1c5250b920d310e0be12acb2a73a5cede3bddc..8adfe4c9f29cbf9d1d6cde6c0fddfdc4527cae5d 100644
--- a/base/files/file_util_posix.cc
+++ b/base/files/file_util_posix.cc
@@ -557,7 +557,7 @@ bool CreateTemporaryDirInDir(const FilePath& base_dir,
return CreateTemporaryDirInDirImpl(base_dir, mkdtemp_template, new_dir);
}
-bool CreateNewTempDirectory(const FilePath::StringType& prefix,
+bool CreateNewTempDirectory(const FilePath::StringType& /* prefix */,
FilePath* new_temp_path) {
FilePath tmpdir;
if (!GetTempDir(&tmpdir))
@@ -845,6 +845,8 @@ bool GetShmemTempDir(bool executable, FilePath* path) {
*path = FilePath("/dev/shm");
return true;
}
+#else
+ (void)executable; // avoid unused warning when !defined(OS_LINUX)
danakj 2016/05/23 02:59:54 capitalize and punctuate comment senetences
Luis Héctor Chávez 2016/05/24 15:27:53 Done.
#endif
return GetTempDir(path);
}

Powered by Google App Engine
This is Rietveld 408576698