libchrome: Several upstreamable fixes from libchrome

base/files/file_util_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_util.h"
 
 #include <dirent.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <libgen.h>
@@ skipping 539 matching lines @@
 }
 
 bool CreateTemporaryDirInDir(const FilePath& base_dir,
                              const FilePath::StringType& prefix,
                              FilePath* new_dir) {
   FilePath::StringType mkdtemp_template = prefix;
   mkdtemp_template.append(FILE_PATH_LITERAL("XXXXXX"));
   return CreateTemporaryDirInDirImpl(base_dir, mkdtemp_template, new_dir);
 }
 
-bool CreateNewTempDirectory(const FilePath::StringType& prefix,
+bool CreateNewTempDirectory(const FilePath::StringType& /* prefix */,
                             FilePath* new_temp_path) {
   FilePath tmpdir;
   if (!GetTempDir(&tmpdir))
     return false;
 
   return CreateTemporaryDirInDirImpl(tmpdir, TempFileName(), new_temp_path);
 }
 
 bool CreateDirectoryAndGetError(const FilePath& full_path,
                                 File::Error* error) {
@@ skipping 267 matching lines @@
 #if defined(OS_LINUX)
   bool use_dev_shm = true;
   if (executable) {
     static const bool s_dev_shm_executable = DetermineDevShmExecutable();
     use_dev_shm = s_dev_shm_executable;
   }
   if (use_dev_shm) {
     *path = FilePath("/dev/shm");
     return true;
   }
+#else
+  (void)executable;  // avoid unused warning when !defined(OS_LINUX)

[danakj, 2016/05/23 02:59:54]

capitalize and punctuate comment senetences

[Luis Héctor Chávez, 2016/05/24 15:27:53]

Done.

 #endif
   return GetTempDir(path);
 }
 #endif  // !defined(OS_ANDROID)
 
 #if !defined(OS_MACOSX)
 // Mac has its own implementation, this is for all other Posix systems.
 bool CopyFile(const FilePath& from_path, const FilePath& to_path) {
   ThreadRestrictions::AssertIOAllowed();
   File infile;
@@ skipping 68 matching lines @@
     return false;
 
   DeleteFile(from_path, true);
   return true;
 }
 
 }  // namespace internal
 
 #endif  // !defined(OS_NACL_NONSFI)
 }  // namespace base