Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1996903002: [Binding] Delete hasInstance() from ArrayBuffer related interfaces (Closed)

Created:
4 years, 7 months ago by peria
Modified:
4 years, 7 months ago
Reviewers:
haraken, Yuki, bashi
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete hasInstance() method from V8ArrayBuffer, V8ArrayBufferView, V8SharedArrayBuffer, and V8{{Type}}Array. We can use v->IsT() instead of T::hasInstance(v, isolate). Files under tests/ were updated by scripts. BUG=613459 Committed: https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2 Cr-Commit-Position: refs/heads/master@{#395052}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -79 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_interface.py View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_union.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/union_container.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/ArrayBufferOrArrayBufferViewOrDictionary.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringOrArrayBufferOrArrayBufferView.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8DataView.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8DataView.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEmpty.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebArrayBufferConverter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
peria
PTL
4 years, 7 months ago (2016-05-20 08:21:43 UTC) #6
Yuki
lgtm
4 years, 7 months ago (2016-05-20 08:27:53 UTC) #7
bashi
https://codereview.chromium.org/1996903002/diff/20001/third_party/WebKit/Source/bindings/templates/union_container.cpp File third_party/WebKit/Source/bindings/templates/union_container.cpp (right): https://codereview.chromium.org/1996903002/diff/20001/third_party/WebKit/Source/bindings/templates/union_container.cpp#newcode13 third_party/WebKit/Source/bindings/templates/union_container.cpp:13: {% macro assign_and_return_if_isinstance(member) %} drive-by: I'd prefer to add ...
4 years, 7 months ago (2016-05-20 08:32:46 UTC) #9
haraken
LGTM
4 years, 7 months ago (2016-05-20 09:16:01 UTC) #10
peria
https://codereview.chromium.org/1996903002/diff/20001/third_party/WebKit/Source/bindings/templates/union_container.cpp File third_party/WebKit/Source/bindings/templates/union_container.cpp (right): https://codereview.chromium.org/1996903002/diff/20001/third_party/WebKit/Source/bindings/templates/union_container.cpp#newcode13 third_party/WebKit/Source/bindings/templates/union_container.cpp:13: {% macro assign_and_return_if_isinstance(member) %} On 2016/05/20 08:32:46, bashi1 wrote: ...
4 years, 7 months ago (2016-05-20 09:26:16 UTC) #11
bashi
LGTM
4 years, 7 months ago (2016-05-20 09:39:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996903002/40001
4 years, 7 months ago (2016-05-20 09:41:47 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-20 10:46:28 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 10:47:37 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2
Cr-Commit-Position: refs/heads/master@{#395052}

Powered by Google App Engine
This is Rietveld 408576698