Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/WebKit/Source/web/WebArrayBufferConverter.cpp

Issue 1996903002: [Binding] Delete hasInstance() from ArrayBuffer related interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/Response.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebArrayBufferConverter.cpp
diff --git a/third_party/WebKit/Source/web/WebArrayBufferConverter.cpp b/third_party/WebKit/Source/web/WebArrayBufferConverter.cpp
index 4235910392403a8c4cf1d1c6b0a0bf30af51e7ce..cb095326e8b3f4df5f30614e559745738613b9cb 100644
--- a/third_party/WebKit/Source/web/WebArrayBufferConverter.cpp
+++ b/third_party/WebKit/Source/web/WebArrayBufferConverter.cpp
@@ -44,10 +44,10 @@ v8::Local<v8::Value> WebArrayBufferConverter::toV8Value(WebArrayBuffer* buffer,
return toV8(*buffer, isolate->GetCurrentContext()->Global(), isolate);
}
-WebArrayBuffer* WebArrayBufferConverter::createFromV8Value(v8::Local<v8::Value> value, v8::Isolate* isolate)
+WebArrayBuffer* WebArrayBufferConverter::createFromV8Value(v8::Local<v8::Value> value, v8::Isolate*)
{
- if (!V8ArrayBuffer::hasInstance(value, isolate))
- return 0;
+ if (!value->IsArrayBuffer())
+ return nullptr;
return new WebArrayBuffer(V8ArrayBuffer::toImpl(value.As<v8::Object>()));
}
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/Response.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698