[Binding] Delete hasInstance() from ArrayBuffer related interfaces

third_party/WebKit/Source/bindings/templates/union_container.cpp

 {% from 'utilities.cpp' import declare_enum_validation_variable %}
 {% include 'copyright_block.txt' %}
 #include "{{this_include_header_name}}.h"
 
 {% from 'utilities.cpp' import v8_value_to_local_cpp_value %}
 {% macro assign_and_return_if_hasinstance(member) %}
 if (V8{{member.type_name}}::hasInstance(v8Value, isolate)) {
     {{member.cpp_local_type}} cppValue = V8{{member.type_name}}::toImpl(v8::Local<v8::Object>::Cast(v8Value));
     impl.set{{member.type_name}}(cppValue);
     return;
 }
 {% endmacro %}
+{% macro assign_and_return_if_isinstance(member) %}

[bashi, 2016/05/20 08:32:46]

drive-by: I'd prefer to add |is_instance_expression| field to member context
rather than adding almost the same macro.

[peria, 2016/05/20 09:26:16]

Done.

+if (v8Value->Is{{member.type_name}}()) {
+    {{member.cpp_local_type}} cppValue = V8{{member.type_name}}::toImpl(v8::Local<v8::Object>::Cast(v8Value));
+    impl.set{{member.type_name}}(cppValue);
+    return;
+}
+{% endmacro %}
 {% for filename in cpp_includes %}
 #include "{{filename}}"
 {% endfor %}
 
 namespace blink {
 
 {{cpp_class}}::{{cpp_class}}()
     : m_type(SpecificTypeNone)
 {
 }
@@ skipping 50 matching lines @@
     if (conversionMode == UnionTypeConversionMode::Nullable && isUndefinedOrNull(v8Value))
         return;
 
     {# 3. Platform objects (interfaces) #}
     {% for interface in interface_types %}
     {{assign_and_return_if_hasinstance(interface) | indent}}
 
     {% endfor %}
     {# 8. ArrayBuffer #}
     {% if array_buffer_type %}
-    {{assign_and_return_if_hasinstance(array_buffer_type) | indent}}
+    {{assign_and_return_if_isinstance(array_buffer_type) | indent}}
 
     {% endif %}
     {# 9., 10. ArrayBufferView #}
     {# FIXME: Individual typed arrays (e.g. Uint8Array) aren't supported yet. #}
     {% if array_buffer_view_type %}
-    {{assign_and_return_if_hasinstance(array_buffer_view_type) | indent}}
+    {{assign_and_return_if_isinstance(array_buffer_view_type) | indent}}
 
     {% endif %}
     {% if dictionary_type %}
     {# 12. Dictionaries #}
     {# FIXME: This should also check "object but not Date or RegExp". Add checks
        when we implement conversions for Date and RegExp. #}
     {# TODO(bashi): The spec doesn't say we should check !IsArray() but otherwise
        we can't distinguish a sequence<T> and a dictionary.
        https://github.com/heycam/webidl/issues/123 #}
     if (isUndefinedOrNull(v8Value) || (v8Value->IsObject() && !v8Value->IsArray())) {
@@ skipping 95 matching lines @@
 }
 
 {{cpp_class}} NativeValueTraits<{{cpp_class}}>::nativeValue(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState)
 {
     {{cpp_class}} impl;
     {{v8_class}}::toImpl(isolate, value, impl, UnionTypeConversionMode::NotNullable, exceptionState);
     return impl;
 }
 
 } // namespace blink