Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: Source/bindings/tests/results/V8TestObject.cpp

Issue 19969004: Update toNativeArray() / toRefPtrNativeArray() do not match Web IDL specification (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nits Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/V8TestObject.cpp b/Source/bindings/tests/results/V8TestObject.cpp
index 4760653d5c775085b549d01524aae771f90633bd..7551278c293ac84aba6a1faa84128359e6e55f0e 100644
--- a/Source/bindings/tests/results/V8TestObject.cpp
+++ b/Source/bindings/tests/results/V8TestObject.cpp
@@ -1839,7 +1839,7 @@ static void floatArrayAttrGetterCallback(v8::Local<v8::String> name, const v8::P
static void floatArrayAttrSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
{
TestObj* imp = V8TestObject::toNative(info.Holder());
- V8TRYCATCH_VOID(Vector<float>, v, toNativeArray<float>(value));
+ V8TRYCATCH_VOID(Vector<float>, v, toNativeArray<float>(value, info.GetIsolate()));
imp->setFloatArray(v);
return;
}
@@ -1868,7 +1868,7 @@ static void doubleArrayAttrGetterCallback(v8::Local<v8::String> name, const v8::
static void doubleArrayAttrSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
{
TestObj* imp = V8TestObject::toNative(info.Holder());
- V8TRYCATCH_VOID(Vector<double>, v, toNativeArray<double>(value));
+ V8TRYCATCH_VOID(Vector<double>, v, toNativeArray<double>(value, info.GetIsolate()));
imp->setDoubleArray(v);
return;
}
@@ -4094,7 +4094,7 @@ static void overloadedMethod7Method(const v8::FunctionCallbackInfo<v8::Value>& a
return;
}
TestObj* imp = V8TestObject::toNative(args.Holder());
- V8TRYCATCH_VOID(Vector<String>, arrayArg, toNativeArray<String>(args[0]));
+ V8TRYCATCH_VOID(Vector<String>, arrayArg, toNativeArray<String>(args[0], args.GetIsolate()));
imp->overloadedMethod(arrayArg);
return;
@@ -4120,7 +4120,7 @@ static void overloadedMethod9Method(const v8::FunctionCallbackInfo<v8::Value>& a
return;
}
TestObj* imp = V8TestObject::toNative(args.Holder());
- V8TRYCATCH_VOID(Vector<String>, arrayArg, toNativeArray<String>(args[0]));
+ V8TRYCATCH_VOID(Vector<String>, arrayArg, toNativeArray<String>(args[0], args.GetIsolate()));
imp->overloadedMethod(arrayArg);
return;
@@ -4133,7 +4133,7 @@ static void overloadedMethod10Method(const v8::FunctionCallbackInfo<v8::Value>&
return;
}
TestObj* imp = V8TestObject::toNative(args.Holder());
- V8TRYCATCH_VOID(Vector<unsigned>, arrayArg, toNativeArray<unsigned>(args[0]));
+ V8TRYCATCH_VOID(Vector<unsigned>, arrayArg, toNativeArray<unsigned>(args[0], args.GetIsolate()));
imp->overloadedMethod(arrayArg);
return;
@@ -4429,7 +4429,7 @@ static void methodWithUnsignedLongSequenceMethod(const v8::FunctionCallbackInfo<
return;
}
TestObj* imp = V8TestObject::toNative(args.Holder());
- V8TRYCATCH_VOID(Vector<unsigned>, unsignedLongSequence, toNativeArray<unsigned>(args[0]));
+ V8TRYCATCH_VOID(Vector<unsigned>, unsignedLongSequence, toNativeArray<unsigned>(args[0], args.GetIsolate()));
imp->methodWithUnsignedLongSequence(unsignedLongSequence);
return;
@@ -4450,7 +4450,7 @@ static void stringArrayFunctionMethod(const v8::FunctionCallbackInfo<v8::Value>&
}
TestObj* imp = V8TestObject::toNative(args.Holder());
ExceptionState es(args.GetIsolate());
- V8TRYCATCH_VOID(Vector<String>, values, toNativeArray<String>(args[0]));
+ V8TRYCATCH_VOID(Vector<String>, values, toNativeArray<String>(args[0], args.GetIsolate()));
Vector<String> result = imp->stringArrayFunction(values, es);
if (es.throwIfNeeded())
return;
« no previous file with comments | « Source/bindings/scripts/deprecated_code_generator_v8.pm ('k') | Source/bindings/tests/results/V8TestTypedefs.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698