Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: Source/bindings/tests/results/V8TestTypedefs.cpp

Issue 19969004: Update toNativeArray() / toRefPtrNativeArray() do not match Web IDL specification (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nits Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/V8TestObject.cpp ('k') | Source/bindings/v8/V8Binding.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/V8TestTypedefs.cpp
diff --git a/Source/bindings/tests/results/V8TestTypedefs.cpp b/Source/bindings/tests/results/V8TestTypedefs.cpp
index 45c2c40654be0c701a5e73fc53fe44f35bd6d6b1..91156204a3df4e3ba4e99ff3fa74c531a4f4e551 100644
--- a/Source/bindings/tests/results/V8TestTypedefs.cpp
+++ b/Source/bindings/tests/results/V8TestTypedefs.cpp
@@ -282,7 +282,7 @@ static void funcMethod(const v8::FunctionCallbackInfo<v8::Value>& args)
return;
}
- V8TRYCATCH_VOID(Vector<int>, x, toNativeArray<int>(args[0]));
+ V8TRYCATCH_VOID(Vector<int>, x, toNativeArray<int>(args[0], args.GetIsolate()));
imp->func(x);
return;
@@ -355,7 +355,7 @@ static void nullableArrayArgMethod(const v8::FunctionCallbackInfo<v8::Value>& ar
return;
}
TestTypedefs* imp = V8TestTypedefs::toNative(args.Holder());
- V8TRYCATCH_VOID(Vector<String>, arrayArg, toNativeArray<String>(args[0]));
+ V8TRYCATCH_VOID(Vector<String>, arrayArg, toNativeArray<String>(args[0], args.GetIsolate()));
imp->nullableArrayArg(arrayArg);
return;
@@ -422,7 +422,7 @@ static void stringArrayFunctionMethod(const v8::FunctionCallbackInfo<v8::Value>&
}
TestTypedefs* imp = V8TestTypedefs::toNative(args.Holder());
ExceptionState es(args.GetIsolate());
- V8TRYCATCH_VOID(Vector<String>, values, toNativeArray<String>(args[0]));
+ V8TRYCATCH_VOID(Vector<String>, values, toNativeArray<String>(args[0], args.GetIsolate()));
Vector<String> result = imp->stringArrayFunction(values, es);
if (es.throwIfNeeded())
return;
@@ -445,7 +445,7 @@ static void stringArrayFunction2Method(const v8::FunctionCallbackInfo<v8::Value>
}
TestTypedefs* imp = V8TestTypedefs::toNative(args.Holder());
ExceptionState es(args.GetIsolate());
- V8TRYCATCH_VOID(Vector<String>, values, toNativeArray<String>(args[0]));
+ V8TRYCATCH_VOID(Vector<String>, values, toNativeArray<String>(args[0], args.GetIsolate()));
Vector<String> result = imp->stringArrayFunction2(values, es);
if (es.throwIfNeeded())
return;
« no previous file with comments | « Source/bindings/tests/results/V8TestObject.cpp ('k') | Source/bindings/v8/V8Binding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698