Source/bindings/scripts/deprecated_code_generator_v8.pm - Issue 19969004: Update toNativeArray() / toRefPtrNativeArray() do not match Web IDL specification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 19969004: Update toNativeArray() / toRefPtrNativeArray() do not match Web IDL specification (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix nits Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/canvas/canvas-lineDash-input-sequence-expected.txt ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/scripts/deprecated_code_generator_v8.pm

diff --git a/Source/bindings/scripts/deprecated_code_generator_v8.pm b/Source/bindings/scripts/deprecated_code_generator_v8.pm

index 94a8d52e8a3df4589bdf9bfdf6c3d9623f8942d1..c080b2b5b7a1863e9c28321aab88e234ce57f7ad 100644

--- a/Source/bindings/scripts/deprecated_code_generator_v8.pm

+++ b/Source/bindings/scripts/deprecated_code_generator_v8.pm

@@ -5162,7 +5162,7 @@ sub JSValueToNative

AddToImplIncludes("V8${arrayOrSequenceType}.h");

return "(toRefPtrNativeArray<${arrayOrSequenceType}, V8${arrayOrSequenceType}>($value, $getIsolate))";

}

- return "toNativeArray<" . GetNativeType($arrayOrSequenceType) . ">($value)";

+ return "toNativeArray<" . GetNativeType($arrayOrSequenceType) . ">($value, $getIsolate)";

}

AddIncludesForType($type);