Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1996513002: Record histograms for DRP secure proxy check failures caused by CPs. (Closed)

Created:
4 years, 7 months ago by sclittle
Modified:
4 years, 7 months ago
Reviewers:
tbansal1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@merged_secure_proxy_tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record histograms for DRP secure proxy check failures caused by CPs. When the user is on a network with a captive portal, oftentimes the Data Reduction Proxy's secure proxy check will fail when it receives a redirect to the captive portal's login page. This CL causes these failures to be recorded in the existing DataReductionProxy.ProbeURLNetError histogram, together with the other possible causes of failure. BUG=613023 Committed: https://crrev.com/75d1dec0ee01ea02d8267d1e09cba0d958d80540 Cr-Commit-Position: refs/heads/master@{#394984}

Patch Set 1 #

Patch Set 2 : Rebased on other CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc View 4 chunks +13 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
sclittle
4 years, 7 months ago (2016-05-19 02:32:04 UTC) #2
tbansal1
lgtm
4 years, 7 months ago (2016-05-19 16:37:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996513002/20001
4 years, 7 months ago (2016-05-20 01:26:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 03:38:04 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 03:39:32 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/75d1dec0ee01ea02d8267d1e09cba0d958d80540
Cr-Commit-Position: refs/heads/master@{#394984}

Powered by Google App Engine
This is Rietveld 408576698