components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc - Issue 1996513002: Record histograms for DRP secure proxy check failures caused by CPs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

Issue 1996513002: Record histograms for DRP secure proxy check failures caused by CPs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@merged_secure_proxy_tests

Patch Set: Rebased on other CL Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

index 4e89e8487456d5efa9316de28571e02cf34d5793..688011e9cb7eaa4eb843792763da501c296675ab 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

@@ -644,7 +644,7 @@ void DataReductionProxyConfig::HandleSecureProxyCheckResponse(

event_creator_->EndSecureProxyCheck(bound_net_log_, status.error(),

http_response_code, success_response);

- if (status.status() == net::URLRequestStatus::FAILED) {

+ if (!status.is_success()) {

if (status.error() == net::ERR_INTERNET_DISCONNECTED) {

RecordSecureProxyCheckFetchResult(INTERNET_DISCONNECTED);

return;

« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc » ('j') | no next file with comments »