Split MediaContentType and AudioFocusType

Split MediaContentType and AudioFocusType

The existing MediaSession::Type does not work well for
Pepper&WebRTC. Spliting MediaContentType for MediaPlayer and
AudioFocusType for MediaSession to gain more control of audio focus.

Explainer for this CL:
https://docs.google.com/a/google.com/document/d/1W4uRH8Wvgau0_GtMda4EOSXRtxFuFLhb9W77sJagJpI/edit?usp=sharing

BUG=626351
Committed: https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321
Cr-Commit-Position: refs/heads/master@{#414800}

[Zhiqiang Zhang (Slow), 2016-05-19 14:50:24]

Patchset #1 (id:1) has been deleted

[Zhiqiang Zhang (Slow), 2016-05-19 16:48:13]

zqzhang@chromium.org changed reviewers:
+ mlamouri@chromium.org

[Zhiqiang Zhang (Slow), 2016-07-07 15:08:04]

Description was changed from

==========
Expose MediaSessionType to WMP to gain flexible control of MediaSession

Work in progress

BUG=<WIP>
==========

to

==========
Split MediaContentType and AudioFocusType

The existing MediaSession::Type does not work well for
Pepper&WebRTC. Spliting MediaContentType for MediaPlayer and
AudioFocusType for MediaSession to gain more control of audio focus.

BUG=626351
==========

[Zhiqiang Zhang (Slow), 2016-07-07 16:30:46]

Patchset #2 (id:40001) has been deleted

[Zhiqiang Zhang (Slow), 2016-07-07 16:32:15]

zqzhang@chromium.org changed reviewers:
+ avayvod@chromium.org

[Zhiqiang Zhang (Slow), 2016-07-07 16:32:15]

Did some refactoring. PTAL!
+avayvod@ if you don't have time to review.

[Zhiqiang Zhang (Slow), 2016-08-18 11:43:38]

Ping! (bringing this CL up in Mounir's review queue)

[mlamouri (slow - plz ping), 2016-08-18 14:33:15]

The idea sgtm. Hopefully, avayvod@ can do the full review.

https://codereview.chromium.org/1996043002/diff/120001/content/browser/media/...
File content/browser/media/session/media_session.h (right):

https://codereview.chromium.org/1996043002/diff/120001/content/browser/media/...
content/browser/media/session/media_session.h:63: };
Maybe re-use AudioFocusType from audio_focus_manager.h? I prefer using
Gain/GrainTransientMayDuck if we split media session and audio focus behaviour.
It makes things clearer.

https://codereview.chromium.org/1996043002/diff/120001/content/renderer/media...
File content/renderer/media/webmediaplayer_ms.cc (right):

https://codereview.chromium.org/1996043002/diff/120001/content/renderer/media...
content/renderer/media/webmediaplayer_ms.cc:185:
media::MediaContentType::Uncontrollable);
Should this be transient to make sure the behaviour doesn't change? We can then
ping perkj@ and magjed@ from the TODO to pick the behaviour they would prefer.

https://codereview.chromium.org/1996043002/diff/120001/media/base/media_conte...
File media/base/media_content_type.h (right):

https://codereview.chromium.org/1996043002/diff/120001/media/base/media_conte...
media/base/media_content_type.h:15: enum class MediaContentType {
I'm not a huge fan of the name but I don't really have a better suggestion.

https://codereview.chromium.org/1996043002/diff/120001/media/base/media_conte...
media/base/media_content_type.h:28: // Utility function for deciding whether a
player is treated as Content type by
nit: s/treated as Content type by/treated as Content based on/ (I think)

[Zhiqiang Zhang (Slow), 2016-08-18 17:31:45]

PTAL. Addressed Mounir's comments.

Rebased onto AudioFocusManager and reusing AudioFocusManager::AudioFocusType in
MediaSession.

https://codereview.chromium.org/1996043002/diff/120001/content/browser/media/...
File content/browser/media/session/media_session.h (right):

https://codereview.chromium.org/1996043002/diff/120001/content/browser/media/...
content/browser/media/session/media_session.h:63: };
On 2016/08/18 14:33:15, Mounir Lamouri wrote:
> Maybe re-use AudioFocusType from audio_focus_manager.h? I prefer using
> Gain/GrainTransientMayDuck if we split media session and audio focus
behaviour.
> It makes things clearer.

This is also my idea when you were preparing AudioFocusManager ;) Done.

https://codereview.chromium.org/1996043002/diff/120001/content/renderer/media...
File content/renderer/media/webmediaplayer_ms.cc (right):

https://codereview.chromium.org/1996043002/diff/120001/content/renderer/media...
content/renderer/media/webmediaplayer_ms.cc:185:
media::MediaContentType::Uncontrollable);
On 2016/08/18 14:33:15, Mounir Lamouri wrote:
> Should this be transient to make sure the behaviour doesn't change? We can
then
> ping perkj@ and magjed@ from the TODO to pick the behaviour they would prefer.

Changed the logic in MediaSession, so that all types other than CONTENT will be
treated as TRANSIENT.
Let's leave it for now and refine later.

[whywhat, 2016-08-18 20:33:42]

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
File content/browser/media/session/media_session.cc (right):

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session.cc:75: }
nit: no need for {} here

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session.cc:78: // If the audio focus is
already granted and is of type Content, there is
nit: this comment needs to be updated

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session.cc:82: // TODO(zqzhang): handle
duckable and uncontrollable.
nit: do you need to file a crbug to track the TODO?

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session.cc:83:
AudioFocusManager::AudioFocusType required_audio_focus_type =
could this be a media::AudioFocutTypeFromMediaContentType or something?
nit: also, prefer if's to ?: unless it fits on one line
nit: s/required/requested/

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session.cc:84: (type ==
media::MediaContentType::Gain)
there's no MediaContentType::Gain, right?

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session.cc:227: // Only content type media
session can be controllable unless it is inactive.
nit: update comment?

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
File content/browser/media/session/media_session.h (right):

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session.h:23: 
nit: remove the blank line

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session.h:25: }
nit: add the // namespace comment

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
File content/browser/media/session/media_session_browsertest.cc (right):

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session_browsertest.cc:39: bool
RequestAudioFocus(MediaSession::AudioFocusType) override { return true; }
nit: did you mean AudioFocusManager::AudioFocusType here and below?

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session_browsertest.cc:1284: 
do we need any new tests covering the AudioFocusType/MediaContentType
combinations unsupported before?

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
File content/browser/media/session/media_session_controller.h (right):

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session_controller.h:14: namespace media {
nit: ditto the namespaced forward declaration style

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
File content/browser/media/session/media_session_controllers_manager.h (right):

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session_controllers_manager.h:16: namespace
media {
nit: ditto

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
File content/browser/media/session/media_session_delegate.h (right):

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session_delegate.h:12: enum class
MediaSessionType;
you meant AudioFocusType probably?

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session_delegate.h:13: }
nit: // namespace media

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
File content/browser/media/session/media_session_delegate_default.cc (right):

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session_delegate_default.cc:40:
AudioFocusManager::AudioFocusType type) {
nit: perhaps use |media_content_type| or |audio_focus_type| consistently
throughout this change since just |type| is now very ambiguous

https://codereview.chromium.org/1996043002/diff/140001/media/base/media_conte...
File media/base/media_content_type.cc (right):

https://codereview.chromium.org/1996043002/diff/140001/media/base/media_conte...
media/base/media_content_type.cc:10: const int kMinimumContentDurationSecs = 5;
nit: define that outside in the unnamed namespace perhaps? that would be easier
to find; or add a blank line after at least

https://codereview.chromium.org/1996043002/diff/140001/media/base/media_conte...
media/base/media_content_type.cc:16: }
nit: add a blank line and // namespace media

https://codereview.chromium.org/1996043002/diff/140001/media/base/media_conte...
File media/base/media_content_type.h (right):

https://codereview.chromium.org/1996043002/diff/140001/media/base/media_conte...
media/base/media_content_type.h:17: Content,
nit: MediaContentType::Content sounds a bit odd, also, primary content sounds a
bit misleading - the page may have 10 videos on it, are they all primary?

What about describing the action the session needs to do with the player?

smth like 

enum class FocusAction {
  GainPause,
  GainDuck,  // do we need a separate one for Transient vs Unpausable at this
point?
  Ignore
};

Maybe we don't need to split it into two then even? Just add ignore to
AudioFocusType and be it?

[Zhiqiang Zhang (Slow), 2016-08-19 15:05:55]

Thanks for reviewing this large patch.
Addressed Anton's comments w/ replies. PTAL.

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
File content/browser/media/session/media_session.cc (right):

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session.cc:75: }
On 2016/08/18 20:33:41, whywhat wrote:
> nit: no need for {} here

Done.

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session.cc:78: // If the audio focus is
already granted and is of type Content, there is
On 2016/08/18 20:33:41, whywhat wrote:
> nit: this comment needs to be updated

Moved these to the next block (early return).

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session.cc:82: // TODO(zqzhang): handle
duckable and uncontrollable.
On 2016/08/18 20:33:41, whywhat wrote:
> nit: do you need to file a crbug to track the TODO?

Done.

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session.cc:83:
AudioFocusManager::AudioFocusType required_audio_focus_type =
On 2016/08/18 20:33:42, whywhat wrote:
> could this be a media::AudioFocutTypeFromMediaContentType or something?
> nit: also, prefer if's to ?: unless it fits on one line

Using if for now. After adding Pepper&WebRTC, we'll decide whether to move the
logic into a helper function.

> nit: s/required/requested/

I think "required" is better, which means the required audio focus for playing
the added player.

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session.cc:84: (type ==
media::MediaContentType::Gain)
On 2016/08/18 20:33:41, whywhat wrote:
> there's no MediaContentType::Gain, right?

Done.

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session.cc:227: // Only content type media
session can be controllable unless it is inactive.
On 2016/08/18 20:33:42, whywhat wrote:
> nit: update comment?

Done.

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
File content/browser/media/session/media_session.h (right):

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session.h:23: 
On 2016/08/18 20:33:42, whywhat wrote:
> nit: remove the blank line

Done.

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session.h:25: }
On 2016/08/18 20:33:42, whywhat wrote:
> nit: add the // namespace comment

Done.

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
File content/browser/media/session/media_session_browsertest.cc (right):

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session_browsertest.cc:39: bool
RequestAudioFocus(MediaSession::AudioFocusType) override { return true; }
On 2016/08/18 20:33:42, whywhat wrote:
> nit: did you mean AudioFocusManager::AudioFocusType here and below?

Done.

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session_browsertest.cc:1284: 
On 2016/08/18 20:33:42, whywhat wrote:
> do we need any new tests covering the AudioFocusType/MediaContentType
> combinations unsupported before?

Maybe after the behaviors are fixed?

Currently we are treating all non-content types as transient.
For duckable and uncontrollable we will treat them differently in the future.

Will file a bug for this.

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
File content/browser/media/session/media_session_controller.h (right):

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session_controller.h:14: namespace media {
On 2016/08/18 20:33:42, whywhat wrote:
> nit: ditto the namespaced forward declaration style

Done.

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
File content/browser/media/session/media_session_controllers_manager.h (right):

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session_controllers_manager.h:16: namespace
media {
On 2016/08/18 20:33:42, whywhat wrote:
> nit: ditto

Done.

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
File content/browser/media/session/media_session_delegate.h (right):

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session_delegate.h:12: enum class
MediaSessionType;
On 2016/08/18 20:33:42, whywhat wrote:
> you meant AudioFocusType probably? 

Removed.

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session_delegate.h:13: }
On 2016/08/18 20:33:42, whywhat wrote:
> nit: // namespace media 

Removed

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
File content/browser/media/session/media_session_delegate_default.cc (right):

https://codereview.chromium.org/1996043002/diff/140001/content/browser/media/...
content/browser/media/session/media_session_delegate_default.cc:40:
AudioFocusManager::AudioFocusType type) {
On 2016/08/18 20:33:42, whywhat wrote:
> nit: perhaps use |media_content_type| or |audio_focus_type| consistently
> throughout this change since just |type| is now very ambiguous

Done.

https://codereview.chromium.org/1996043002/diff/140001/media/base/media_conte...
File media/base/media_content_type.cc (right):

https://codereview.chromium.org/1996043002/diff/140001/media/base/media_conte...
media/base/media_content_type.cc:10: const int kMinimumContentDurationSecs = 5;
On 2016/08/18 20:33:42, whywhat wrote:
> nit: define that outside in the unnamed namespace perhaps? that would be
easier
> to find; or add a blank line after at least

Done.

https://codereview.chromium.org/1996043002/diff/140001/media/base/media_conte...
media/base/media_content_type.cc:16: }
On 2016/08/18 20:33:42, whywhat wrote:
> nit: add a blank line and // namespace media

Done.

https://codereview.chromium.org/1996043002/diff/140001/media/base/media_conte...
File media/base/media_content_type.h (right):

https://codereview.chromium.org/1996043002/diff/140001/media/base/media_conte...
media/base/media_content_type.h:17: Content,
On 2016/08/18 20:33:42, whywhat wrote:
> nit: MediaContentType::Content sounds a bit odd, also, primary content sounds
a
> bit misleading - the page may have 10 videos on it, are they all primary?
> 

Maybe we call them "Persistent" as opposed to "Transient"?

> What about describing the action the session needs to do with the player?
> 
> smth like 
> 
> enum class FocusAction {
>   GainPause,
>   GainDuck,  // do we need a separate one for Transient vs Unpausable at this
> point?
>   Ignore
> };
> 
> Maybe we don't need to split it into two then even? Just add ignore to
> AudioFocusType and be it?

We should consider Pepper, which will be specially treated in MediaSession in
follow-up patches. Thus I think we should split it.

Also with Pepper, "FocusAction" might not be a good name :(

Renamed "Unpausable" to "Pepper"

[Zhiqiang Zhang (Slow), 2016-08-19 15:06:27]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 15:06:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 20:43:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 20:43:56]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[whywhat, 2016-08-19 23:34:48]

lgtm

Thanks for addressing my comments.

[Zhiqiang Zhang (Slow), 2016-08-22 10:12:37]

Description was changed from

==========
Split MediaContentType and AudioFocusType

The existing MediaSession::Type does not work well for
Pepper&WebRTC. Spliting MediaContentType for MediaPlayer and
AudioFocusType for MediaSession to gain more control of audio focus.

BUG=626351
==========

to

==========
Split MediaContentType and AudioFocusType

The existing MediaSession::Type does not work well for
Pepper&WebRTC. Spliting MediaContentType for MediaPlayer and
AudioFocusType for MediaSession to gain more control of audio focus.

Explainer for this CL:
https://docs.google.com/a/google.com/document/d/1W4uRH8Wvgau0_GtMda4EOSXRtxFu...

BUG=626351
==========

[Zhiqiang Zhang (Slow), 2016-08-22 10:15:52]

zqzhang@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[Zhiqiang Zhang (Slow), 2016-08-22 10:15:53]

+dalecurtis@ for approval.

Sorry the CL has to be so big, added an explainer in the CL description.

[DaleCurtis, 2016-08-22 17:37:22]

lgtm

https://codereview.chromium.org/1996043002/diff/180001/media/base/media_conte...
File media/base/media_content_type.cc (right):

https://codereview.chromium.org/1996043002/diff/180001/media/base/media_conte...
media/base/media_content_type.cc:14: return (duration.is_zero() ||
Should probably add a comment about the zero case.

[Zhiqiang Zhang (Slow), 2016-08-22 18:04:49]

zqzhang@chromium.org changed reviewers:
+ dcheng@chromium.org, jochen@chromium.org

[Zhiqiang Zhang (Slow), 2016-08-22 18:04:50]

+dcheng to review media_player_delegate_messages.h

+jochen to rubberstamp web_contents_impl_unittest.cc

[Zhiqiang Zhang (Slow), 2016-08-22 18:06:58]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 18:08:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 22:40:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 22:40:24]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-08-23 12:47:45]

lgtm

[mlamouri (slow - plz ping), 2016-08-23 13:19:04]

lgtm

https://codereview.chromium.org/1996043002/diff/200001/media/base/media_conte...
File media/base/media_content_type.h (right):

https://codereview.chromium.org/1996043002/diff/200001/media/base/media_conte...
media/base/media_content_type.h:23: // player instead of pausing it.
style: you seem to
break lines
too
often
:)

[Zhiqiang Zhang (Slow), 2016-08-25 09:31:43]

Ping!
dcheng@, can you review the IPC change? It should be trivial enough.

[Zhiqiang Zhang (Slow), 2016-08-25 10:52:54]

+tsepez@ for review IPC message changes

[Zhiqiang Zhang (Slow), 2016-08-25 10:53:43]

zqzhang@chromium.org changed reviewers:
+ tsepez@chromium.org

[Zhiqiang Zhang (Slow), 2016-08-25 10:53:43]

+tsepez@ to review IPC message changes.

[Tom Sepez, 2016-08-25 19:25:32]

Messages LGTM with nit.

https://codereview.chromium.org/1996043002/diff/200001/media/base/media_conte...
File media/base/media_content_type.h (right):

https://codereview.chromium.org/1996043002/diff/200001/media/base/media_conte...
media/base/media_content_type.h:30: // Utility function for deciding whether a
player is treated as Content type
nit: for deciding the MediaContentType of a player based on its duration.

[Zhiqiang Zhang (Slow), 2016-08-26 10:26:20]

https://codereview.chromium.org/1996043002/diff/200001/media/base/media_conte...
File media/base/media_content_type.h (right):

https://codereview.chromium.org/1996043002/diff/200001/media/base/media_conte...
media/base/media_content_type.h:23: // player instead of pausing it.
On 2016/08/23 13:19:04, mlamouri (slow) wrote:
> style: you seem to
> break lines
> too
> often
> :)

Done.

https://codereview.chromium.org/1996043002/diff/200001/media/base/media_conte...
media/base/media_content_type.h:30: // Utility function for deciding whether a
player is treated as Content type
On 2016/08/25 19:25:32, Tom Sepez wrote:
> nit: for deciding the MediaContentType of a player based on its duration. 

Done.

[Zhiqiang Zhang (Slow), 2016-08-26 10:26:29]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2016-08-26 10:26:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
avayvod@chromium.org, dalecurtis@chromium.org, jochen@chromium.org,
mlamouri@chromium.org, tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1996043002/#ps220001
(title: "addressed nits")

[commit-bot: I haz the power, 2016-08-26 10:26:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 13:44:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 13:44:10]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Zhiqiang Zhang (Slow), 2016-08-26 13:47:32]

The CQ bit was checked by zqzhang@chromium.org

[commit-bot: I haz the power, 2016-08-26 13:48:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 16:59:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 16:59:03]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Zhiqiang Zhang (Slow), 2016-08-26 17:02:42]

The CQ bit was checked by zqzhang@chromium.org

[commit-bot: I haz the power, 2016-08-26 17:03:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 20:34:48]

Description was changed from

==========
Split MediaContentType and AudioFocusType

The existing MediaSession::Type does not work well for
Pepper&WebRTC. Spliting MediaContentType for MediaPlayer and
AudioFocusType for MediaSession to gain more control of audio focus.

Explainer for this CL:
https://docs.google.com/a/google.com/document/d/1W4uRH8Wvgau0_GtMda4EOSXRtxFu...

BUG=626351
==========

to

==========
Split MediaContentType and AudioFocusType

The existing MediaSession::Type does not work well for
Pepper&WebRTC. Spliting MediaContentType for MediaPlayer and
AudioFocusType for MediaSession to gain more control of audio focus.

Explainer for this CL:
https://docs.google.com/a/google.com/document/d/1W4uRH8Wvgau0_GtMda4EOSXRtxFu...

BUG=626351
==========

[commit-bot: I haz the power, 2016-08-26 20:34:50]

Committed patchset #10 (id:220001)

[commit-bot: I haz the power, 2016-08-26 20:36:22]

Description was changed from

==========
Split MediaContentType and AudioFocusType

The existing MediaSession::Type does not work well for
Pepper&WebRTC. Spliting MediaContentType for MediaPlayer and
AudioFocusType for MediaSession to gain more control of audio focus.

Explainer for this CL:
https://docs.google.com/a/google.com/document/d/1W4uRH8Wvgau0_GtMda4EOSXRtxFu...

BUG=626351
==========

to

==========
Split MediaContentType and AudioFocusType

The existing MediaSession::Type does not work well for
Pepper&WebRTC. Spliting MediaContentType for MediaPlayer and
AudioFocusType for MediaSession to gain more control of audio focus.

Explainer for this CL:
https://docs.google.com/a/google.com/document/d/1W4uRH8Wvgau0_GtMda4EOSXRtxFu...

BUG=626351

Committed: https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321
Cr-Commit-Position: refs/heads/master@{#414800}
==========

[commit-bot: I haz the power, 2016-08-26 20:36:24]

Patchset 10 (id:??) landed as
https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321
Cr-Commit-Position: refs/heads/master@{#414800}