media/base/media_content_type.cc - Issue 1996043002: Split MediaContentType and AudioFocusType

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/base/media_content_type.cc

Issue 1996043002: Split MediaContentType and AudioFocusType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Mounir's comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "media/base/media_content_type.h"

	6

	7 namespace media {

	8

	9 MediaContentType DurationToMediaContentType(base::TimeDelta duration) {

	10 const int kMinimumContentDurationSecs = 5;
	whywhat 2016/08/18 20:33:42 nit: define that outside in the unnamed namespace nit: define that outside in the unnamed namespace perhaps? that would be easier to find; or add a blank line after at least Zhiqiang Zhang (Slow) 2016/08/19 15:05:55 Done. Show quoted text On 2016/08/18 20:33:42, whywhat wrote: > nit: define that outside in the unnamed namespace perhaps? that would be easier > to find; or add a blank line after at least Done.
	11 return (duration.is_zero() \|\|

	12 duration > base::TimeDelta::FromSeconds(kMinimumContentDurationSecs))

	13 ? MediaContentType::Content

	14 : MediaContentType::Transient;

	15 }

	16 }
	whywhat 2016/08/18 20:33:42 nit: add a blank line and // namespace media nit: add a blank line and // namespace media Zhiqiang Zhang (Slow) 2016/08/19 15:05:55 Done. Show quoted text On 2016/08/18 20:33:42, whywhat wrote: > nit: add a blank line and // namespace media Done.
OLD	NEW