third_party/WebKit/Source/core/editing/CaretBase.cpp - Issue 1994883002: [Editing][CodeHealth] Extract new FrameCaret class from FrameSelection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/CaretBase.cpp

Issue 1994883002: [Editing][CodeHealth] Extract new FrameCaret class from FrameSelection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/CaretBase.h ('k') | third_party/WebKit/Source/core/editing/DragCaretController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/CaretBase.cpp

diff --git a/third_party/WebKit/Source/core/editing/CaretBase.cpp b/third_party/WebKit/Source/core/editing/CaretBase.cpp

index 1b4a8f0db8493ee309eaced8f6f1e16349c86d6f..0a75091c2c0c9988db03e251b9784d3d733c55f2 100644

--- a/third_party/WebKit/Source/core/editing/CaretBase.cpp

+++ b/third_party/WebKit/Source/core/editing/CaretBase.cpp

@@ -43,6 +43,12 @@ CaretBase::CaretBase(CaretVisibility visibility)

{

}

+CaretBase::~CaretBase() = default;

+DEFINE_TRACE(CaretBase)

void CaretBase::clearCaretRect()

{

m_caretLocalRect = LayoutRect();

« no previous file with comments | « third_party/WebKit/Source/core/editing/CaretBase.h ('k') | third_party/WebKit/Source/core/editing/DragCaretController.h » ('j') | no next file with comments »