Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: third_party/WebKit/Source/core/editing/CaretBase.h

Issue 1994883002: [Editing][CodeHealth] Extract new FrameCaret class from FrameSelection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/editing/CaretBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/CaretBase.h
diff --git a/third_party/WebKit/Source/core/editing/CaretBase.h b/third_party/WebKit/Source/core/editing/CaretBase.h
index 05f064bf9e612fd3b312eb5e0d5694d95e904115..d1c7736eca87d3e2d375dd60fe5cc97d2d9496c7 100644
--- a/third_party/WebKit/Source/core/editing/CaretBase.h
+++ b/third_party/WebKit/Source/core/editing/CaretBase.h
@@ -42,10 +42,11 @@ class LayoutViewItem;
enum class CaretVisibility { Visible, Hidden };
-class CORE_EXPORT CaretBase {
+class CORE_EXPORT CaretBase : public GarbageCollectedFinalized<CaretBase> {
WTF_MAKE_NONCOPYABLE(CaretBase);
public:
explicit CaretBase(CaretVisibility = CaretVisibility::Hidden);
+ virtual ~CaretBase();
void invalidateCaretRect(Node*, bool caretRectChanged = false);
void clearCaretRect();
@@ -68,6 +69,8 @@ public:
static LayoutBlock* caretLayoutObject(Node*);
static void invalidateLocalCaretRect(Node*, const LayoutRect&);
+ DECLARE_VIRTUAL_TRACE();
+
private:
LayoutRect m_caretLocalRect; // caret rect in coords local to the layoutObject responsible for painting the caret
CaretVisibility m_caretVisibility;
« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/editing/CaretBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698