third_party/WebKit/Source/core/editing/DragCaretController.h - Issue 1994883002: [Editing][CodeHealth] Extract new FrameCaret class from FrameSelection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/DragCaretController.h

Issue 1994883002: [Editing][CodeHealth] Extract new FrameCaret class from FrameSelection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/CaretBase.cpp ('k') | third_party/WebKit/Source/core/editing/DragCaretController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/DragCaretController.h

diff --git a/third_party/WebKit/Source/core/editing/DragCaretController.h b/third_party/WebKit/Source/core/editing/DragCaretController.h

index bcb0134cd4d2524ac2c5f319dfbb31a0c9f210b6..00d4f8450c292f10b169bef24d042e6bf9774426 100644

--- a/third_party/WebKit/Source/core/editing/DragCaretController.h

+++ b/third_party/WebKit/Source/core/editing/DragCaretController.h

@@ -28,8 +28,6 @@

#include "core/editing/CaretBase.h"

-#include <memory>

namespace blink {

class DragCaretController final : public GarbageCollectedFinalized<DragCaretController> {

@@ -56,7 +54,7 @@ private:

DragCaretController();

VisiblePosition m_position;

- const std::unique_ptr<CaretBase> m_caretBase;

+ const Member<CaretBase> m_caretBase;

};

} // namespace blink