Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1994883002: [Editing][CodeHealth] Extract new FrameCaret class from FrameSelection (Closed)

Created:
4 years, 7 months ago by yoichio
Modified:
4 years, 7 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Editing][CodeHealth] Extract new FrameCaret class from FrameSelection Create new FrameCaret to own caret painting in FrameSelection. This is a kind of refactoring and many of them are in FrameSelection.cpp with renaming for ease of reading. I will move them to FrameCaret.cpp later. TEST=no change in behavior Committed: https://crrev.com/5bd604e399dd7e7ceb54ad520d74cf829221de7e Cr-Commit-Position: refs/heads/master@{#395290}

Patch Set 1 #

Patch Set 2 : update #

Total comments: 18

Patch Set 3 : update #

Total comments: 8

Patch Set 4 : update #

Total comments: 8

Patch Set 5 : update #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -79 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretBase.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/CaretBase.cpp View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DragCaretController.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DragCaretController.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/FrameCaret.h View 1 2 3 4 1 chunk +79 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/FrameCaret.cpp View 1 2 3 4 1 chunk +50 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 2 3 4 5 5 chunks +7 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 2 3 4 5 13 chunks +135 lines, -57 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
yoichio
4 years, 7 months ago (2016-05-19 08:02:38 UTC) #3
yosin_UTC9
https://codereview.chromium.org/1994883002/diff/20001/third_party/WebKit/Source/core/editing/FrameCaret.cpp File third_party/WebKit/Source/core/editing/FrameCaret.cpp (right): https://codereview.chromium.org/1994883002/diff/20001/third_party/WebKit/Source/core/editing/FrameCaret.cpp#newcode1 third_party/WebKit/Source/core/editing/FrameCaret.cpp:1: // Copyright 2016 The Chromium Authors. All rights reserved. ...
4 years, 7 months ago (2016-05-19 08:32:37 UTC) #4
yoichio
https://codereview.chromium.org/1994883002/diff/20001/third_party/WebKit/Source/core/editing/FrameCaret.cpp File third_party/WebKit/Source/core/editing/FrameCaret.cpp (right): https://codereview.chromium.org/1994883002/diff/20001/third_party/WebKit/Source/core/editing/FrameCaret.cpp#newcode1 third_party/WebKit/Source/core/editing/FrameCaret.cpp:1: // Copyright 2016 The Chromium Authors. All rights reserved. ...
4 years, 7 months ago (2016-05-20 05:12:13 UTC) #5
yosin_UTC9
https://codereview.chromium.org/1994883002/diff/40001/third_party/WebKit/Source/core/editing/CaretBase.h File third_party/WebKit/Source/core/editing/CaretBase.h (right): https://codereview.chromium.org/1994883002/diff/40001/third_party/WebKit/Source/core/editing/CaretBase.h#newcode49 third_party/WebKit/Source/core/editing/CaretBase.h:49: virtual ~CaretBase() { } nit: virtual dtor should not ...
4 years, 7 months ago (2016-05-20 07:18:05 UTC) #6
yoichio
https://codereview.chromium.org/1994883002/diff/40001/third_party/WebKit/Source/core/editing/CaretBase.h File third_party/WebKit/Source/core/editing/CaretBase.h (right): https://codereview.chromium.org/1994883002/diff/40001/third_party/WebKit/Source/core/editing/CaretBase.h#newcode49 third_party/WebKit/Source/core/editing/CaretBase.h:49: virtual ~CaretBase() { } On 2016/05/20 07:18:05, Yosi_UTC9 wrote: ...
4 years, 7 months ago (2016-05-20 07:50:00 UTC) #7
yosin_UTC9
lgtm w/ nits +tken@ for core.gypi changes https://codereview.chromium.org/1994883002/diff/60001/third_party/WebKit/Source/core/core.gypi File third_party/WebKit/Source/core/core.gypi (right): https://codereview.chromium.org/1994883002/diff/60001/third_party/WebKit/Source/core/core.gypi#newcode1471 third_party/WebKit/Source/core/core.gypi:1471: 'editing/FrameCaret.cpp', Please ...
4 years, 7 months ago (2016-05-20 07:53:13 UTC) #9
tkent
lgtm https://codereview.chromium.org/1994883002/diff/60001/third_party/WebKit/Source/core/editing/FrameCaret.h File third_party/WebKit/Source/core/editing/FrameCaret.h (right): https://codereview.chromium.org/1994883002/diff/60001/third_party/WebKit/Source/core/editing/FrameCaret.h#newcode34 third_party/WebKit/Source/core/editing/FrameCaret.h:34: class FrameCaret : public CaretBase { If you ...
4 years, 7 months ago (2016-05-20 08:18:06 UTC) #10
yoichio
https://codereview.chromium.org/1994883002/diff/60001/third_party/WebKit/Source/core/core.gypi File third_party/WebKit/Source/core/core.gypi (right): https://codereview.chromium.org/1994883002/diff/60001/third_party/WebKit/Source/core/core.gypi#newcode1471 third_party/WebKit/Source/core/core.gypi:1471: 'editing/FrameCaret.cpp', On 2016/05/20 07:53:13, Yosi_UTC9 wrote: > Please add ...
4 years, 7 months ago (2016-05-20 08:58:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994883002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994883002/80001
4 years, 7 months ago (2016-05-20 08:58:23 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/9089) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-20 09:00:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994883002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994883002/100001
4 years, 7 months ago (2016-05-23 04:18:59 UTC) #19
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-05-23 06:47:38 UTC) #21
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 06:49:07 UTC) #23
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/5bd604e399dd7e7ceb54ad520d74cf829221de7e
Cr-Commit-Position: refs/heads/master@{#395290}

Powered by Google App Engine
This is Rietveld 408576698