Add !IsArray() check for dictionary conversion in union types

Add !IsArray() check for dictionary conversion in union types

A sequence<T> and a dictionary are distinguishable. If a JS object
is an array we want to convert it as a sequence.

Committed: https://crrev.com/c00923d5bc482e609764ea3020cc79a4506e63b1
Cr-Commit-Position: refs/heads/master@{#394739}

[bashi, 2016-05-19 01:41:27]

bashi@chromium.org changed reviewers:
+ hta@chromium.org

[bashi, 2016-05-19 01:41:27]

hta@: could you try this CL to see if this work for you?

[hta - Chromium, 2016-05-19 06:38:35]

This works beautifully for me - thanks!

(I assume there will be a test case added too).

https://codereview.chromium.org/1994823002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/union_container.cpp (right):

https://codereview.chromium.org/1994823002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/union_container.cpp:97: we can't
distinguish a sequence<T> and a dictionary. #}
Should there be a link to the bug filed against the spec here?

[hta - Chromium, 2016-05-19 08:17:45]

lgtm

[bashi, 2016-05-19 08:21:14]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org

[bashi, 2016-05-19 08:21:14]

No actual behavior test for now but I'll add a test once the spec is updated.

Haraken-san, PTAL?

https://codereview.chromium.org/1994823002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/union_container.cpp (right):

https://codereview.chromium.org/1994823002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/union_container.cpp:97: we can't
distinguish a sequence<T> and a dictionary. #}
On 2016/05/19 06:38:35, hta - Chromium wrote:
> Should there be a link to the bug filed against the spec here?

Done.

[haraken, 2016-05-19 08:28:18]

LGTM

[bashi, 2016-05-19 08:28:56]

The CQ bit was checked by bashi@chromium.org

[bashi, 2016-05-19 08:28:56]

The patchset sent to the CQ was uploaded after l-g-t-m from hta@chromium.org
Link to the patchset: https://codereview.chromium.org/1994823002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-05-19 08:29:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994823002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1994823002/20001

[commit-bot: I haz the power, 2016-05-19 09:37:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 09:37:10]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hta - Chromium, 2016-05-19 10:18:20]

The CQ bit was checked by hta@chromium.org

[commit-bot: I haz the power, 2016-05-19 10:18:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994823002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1994823002/20001

[commit-bot: I haz the power, 2016-05-19 11:37:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-19 11:38:43]

Description was changed from

==========
Add !IsArray() check for dictionary conversion in union types

A sequence<T> and a dictionary are distinguishable. If a JS object
is an array we want to convert it as a sequence.
==========

to

==========
Add !IsArray() check for dictionary conversion in union types

A sequence<T> and a dictionary are distinguishable. If a JS object
is an array we want to convert it as a sequence.

Committed: https://crrev.com/c00923d5bc482e609764ea3020cc79a4506e63b1
Cr-Commit-Position: refs/heads/master@{#394739}
==========

[commit-bot: I haz the power, 2016-05-19 11:38:44]

Patchset 2 (id:??) landed as
https://crrev.com/c00923d5bc482e609764ea3020cc79a4506e63b1
Cr-Commit-Position: refs/heads/master@{#394739}