third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp - Issue 1994823002: Add !IsArray() check for dictionary conversion in union types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp

Issue 1994823002: Add !IsArray() check for dictionary conversion in union types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp b/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp

index 164ef81446da5cacffb963ed917fefe54d503ec7..f0bca72bab76295bb8186127cdf9d693af977ab5 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp

@@ -74,7 +74,7 @@ void V8LongOrTestDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v

if (conversionMode == UnionTypeConversionMode::Nullable && isUndefinedOrNull(v8Value))

return;

- if (isUndefinedOrNull(v8Value) || v8Value->IsObject()) {

+ if (isUndefinedOrNull(v8Value) || (v8Value->IsObject() && !v8Value->IsArray())) {

TestDictionary cppValue;

V8TestDictionary::toImpl(isolate, v8Value, cppValue, exceptionState);

if (exceptionState.hadException())

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/union_container.cpp ('k') | no next file » | no next file with comments »