telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it stops

telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it stops

Stop measuring tough_path_rendering_cases chalkboard test-case after the
page stops its "benchmark" and presents the results.

The page used to wait 20s. On my desktop it runs <10s and on my
particular Android device, ~17s.

This avoids measuring the page after it stops updating.

Committed: https://crrev.com/6a26af29d26f974d63d78f2a29757f0f8f6162f4
Cr-Commit-Position: refs/heads/master@{#399432}

[Kimmo Kinnunen, 2016-05-19 08:10:57]

kkinnunen@nvidia.com changed reviewers:
+ nednguyen@google.com, senorblanco@google.com

[Kimmo Kinnunen, 2016-05-19 08:10:57]

I noticed nednguyen@ was concerned about test length.
Does it make sense to measure chalkboard only while it is updating, and stop
after the test becomes idle?

[nednguyen, 2016-05-19 15:24:35]

lgtm

[Stephen White, 2016-05-19 15:26:41]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2016-05-19 15:26:45]

https://codereview.chromium.org/1994653004/diff/1/tools/perf/page_sets/tough_...
File tools/perf/page_sets/tough_path_rendering_cases.py (right):

https://codereview.chromium.org/1994653004/diff/1/tools/perf/page_sets/tough_...
tools/perf/page_sets/tough_path_rendering_cases.py:18:
action_runner.tab.WaitForDocumentReadyStateToBeComplete()
Hmmm! Note to self: we should probably add this to the "Pirates" demo too (under
tough_filters_cases).

https://codereview.chromium.org/1994653004/diff/1/tools/perf/page_sets/tough_...
tools/perf/page_sets/tough_path_rendering_cases.py:23:
'document.getElementById("FinalTime").innerText != ""')
It would be really cool to gather the actual value here, if available.

[Stephen White, 2016-05-19 15:27:20]

LGTM

[Kimmo Kinnunen, 2016-05-20 10:54:43]

https://codereview.chromium.org/1994653004/diff/1/tools/perf/page_sets/tough_...
File tools/perf/page_sets/tough_path_rendering_cases.py (right):

https://codereview.chromium.org/1994653004/diff/1/tools/perf/page_sets/tough_...
tools/perf/page_sets/tough_path_rendering_cases.py:23:
'document.getElementById("FinalTime").innerText != ""')
On 2016/05/19 15:26:41, Stephen White wrote:
> It would be really cool to gather the actual value here, if available.

So would this be another "benchmark" in addition to smoothness?
If I understand correctly "smoothness" measures "smoothness" numbers, not for
example this number?

I can try to create a new benchmark that would produce the chalkboar result
number. I can try to add those tiger numbers to that or similar benchmark.

[Stephen White, 2016-05-20 13:25:12]

https://codereview.chromium.org/1994653004/diff/1/tools/perf/page_sets/tough_...
File tools/perf/page_sets/tough_path_rendering_cases.py (right):

https://codereview.chromium.org/1994653004/diff/1/tools/perf/page_sets/tough_...
tools/perf/page_sets/tough_path_rendering_cases.py:23:
'document.getElementById("FinalTime").innerText != ""')
On 2016/05/20 10:54:42, Kimmo Kinnunen wrote:
> On 2016/05/19 15:26:41, Stephen White wrote:
> > It would be really cool to gather the actual value here, if available.
> 
> So would this be another "benchmark" in addition to smoothness?
> If I understand correctly "smoothness" measures "smoothness" numbers, not for
> example this number?

I had assumed it could just be added to the existing values collected without
creating a 
new benchmark type. But to be honest, I don't know enough about Telemetry to
say.
Maybe the infrastructure folks could shed some light?

> I can try to create a new benchmark that would produce the chalkboar result
> number. I can try to add those tiger numbers to that or similar benchmark.

It was definitely not a requirement to get your stuff landed, just something
I've 
wanted to collect. frame_times is the only value we alert on for these tests,
and
I think that's fine for now.

[Kimmo Kinnunen, 2016-06-13 10:43:08]

The CQ bit was checked by kkinnunen@nvidia.com

[Kimmo Kinnunen, 2016-06-13 10:43:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
nednguyen@google.com, senorblanco@chromium.org
Link to the patchset: https://codereview.chromium.org/1994653004/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-13 10:43:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994653004/20001

[commit-bot: I haz the power, 2016-06-13 12:02:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-13 12:04:12]

Description was changed from

==========
telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it
stops

Stop measuring tough_path_rendering_cases chalkboard test-case after the
page stops its "benchmark" and presents the results.

The page used to wait 20s. On my desktop it runs <10s and on my
particular Android device, ~17s.

This avoids measuring the page after it stops updating.
==========

to

==========
telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it
stops

Stop measuring tough_path_rendering_cases chalkboard test-case after the
page stops its "benchmark" and presents the results.

The page used to wait 20s. On my desktop it runs <10s and on my
particular Android device, ~17s.

This avoids measuring the page after it stops updating.

Committed: https://crrev.com/6a26af29d26f974d63d78f2a29757f0f8f6162f4
Cr-Commit-Position: refs/heads/master@{#399432}
==========

[commit-bot: I haz the power, 2016-06-13 12:04:14]

Patchset 2 (id:??) landed as
https://crrev.com/6a26af29d26f974d63d78f2a29757f0f8f6162f4
Cr-Commit-Position: refs/heads/master@{#399432}

[Zhen Wang, 2016-06-13 21:55:01]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2063013002/ by zhenw@chromium.org.

The reason for reverting is: smoothness.tough_path_rendering_cases fails on
Android Nexus5 Perf (1) and Android Nexus7v2 Perf (1) bots.

Seems clear that this CL causes it.

BUG=619716.