tools/perf/page_sets/tough_path_rendering_cases.py - Issue 1994653004: telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it stops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/tough_path_rendering_cases.py

Issue 1994653004: telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it stops (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-chalkboard-recording

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/tough_path_rendering_cases.py

diff --git a/tools/perf/page_sets/tough_path_rendering_cases.py b/tools/perf/page_sets/tough_path_rendering_cases.py

index 1748ddb4362121262945b2a81312991a0e436439..924576033beca6b63a3c4f4517b571f329d491de 100644

--- a/tools/perf/page_sets/tough_path_rendering_cases.py

+++ b/tools/perf/page_sets/tough_path_rendering_cases.py

@@ -15,10 +15,12 @@ class ToughPathRenderingCasesPage(page_module.Page):

class ChalkboardPage(page_module.Page):

def RunPageInteractions(self, action_runner):

+ action_runner.tab.WaitForDocumentReadyStateToBeComplete()

with action_runner.CreateInteraction('ClickStart'):

action_runner.EvaluateJavaScript(

'document.getElementById("StartButton").click()')

- action_runner.Wait(20)

+ action_runner.WaitForJavaScriptCondition(

+ 'document.getElementById("FinalTime").innerText != ""')

class ToughPathRenderingCasesPageSet(story.StorySet):

« no previous file with comments | « no previous file | no next file » | no next file with comments »