Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: tools/perf/page_sets/tough_path_rendering_cases.py

Issue 1994653004: telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it stops (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-chalkboard-recording
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 from telemetry.page import page as page_module 4 from telemetry.page import page as page_module
5 from telemetry import story 5 from telemetry import story
6 6
7 7
8 class ToughPathRenderingCasesPage(page_module.Page): 8 class ToughPathRenderingCasesPage(page_module.Page):
9 9
10 def RunPageInteractions(self, action_runner): 10 def RunPageInteractions(self, action_runner):
11 with action_runner.CreateInteraction('ClickStart'): 11 with action_runner.CreateInteraction('ClickStart'):
12 action_runner.Wait(10) 12 action_runner.Wait(10)
13 13
14 14
15 class ChalkboardPage(page_module.Page): 15 class ChalkboardPage(page_module.Page):
16 16
17 def RunPageInteractions(self, action_runner): 17 def RunPageInteractions(self, action_runner):
18 action_runner.tab.WaitForDocumentReadyStateToBeComplete()
Stephen White 2016/05/19 15:26:41 Hmmm! Note to self: we should probably add this to
18 with action_runner.CreateInteraction('ClickStart'): 19 with action_runner.CreateInteraction('ClickStart'):
19 action_runner.EvaluateJavaScript( 20 action_runner.EvaluateJavaScript(
20 'document.getElementById("StartButton").click()') 21 'document.getElementById("StartButton").click()')
21 action_runner.Wait(20) 22 action_runner.WaitForJavaScriptCondition(
23 'document.getElementById("FinalTime").innerText != ""')
Stephen White 2016/05/19 15:26:41 It would be really cool to gather the actual value
Kimmo Kinnunen 2016/05/20 10:54:42 So would this be another "benchmark" in addition t
Stephen White 2016/05/20 13:25:12 I had assumed it could just be added to the existi
22 24
23 class ToughPathRenderingCasesPageSet(story.StorySet): 25 class ToughPathRenderingCasesPageSet(story.StorySet):
24 26
25 """ 27 """
26 Description: Self-driven path rendering examples 28 Description: Self-driven path rendering examples
27 """ 29 """
28 30
29 def __init__(self): 31 def __init__(self):
30 super(ToughPathRenderingCasesPageSet, self).__init__( 32 super(ToughPathRenderingCasesPageSet, self).__init__(
31 archive_data_file='data/tough_path_rendering_cases.json', 33 archive_data_file='data/tough_path_rendering_cases.json',
32 cloud_storage_bucket=story.PARTNER_BUCKET) 34 cloud_storage_bucket=story.PARTNER_BUCKET)
33 35
34 urls_list = [ 36 urls_list = [
35 'http://www.craftymind.com/factory/guimark2/HTML5ChartingTest.html' 37 'http://www.craftymind.com/factory/guimark2/HTML5ChartingTest.html'
36 ] 38 ]
37 39
38 for url in urls_list: 40 for url in urls_list:
39 self.AddStory(ToughPathRenderingCasesPage(url, self)) 41 self.AddStory(ToughPathRenderingCasesPage(url, self))
40 42
41 # Chalkboard content linked from http://ie.microsoft.com/testdrive/Performan ce/Chalkboard/. 43 # Chalkboard content linked from http://ie.microsoft.com/testdrive/Performan ce/Chalkboard/.
42 self.AddStory(ChalkboardPage( 44 self.AddStory(ChalkboardPage(
43 'https://testdrive-archive.azurewebsites.net/performance/chalkboard/', s elf)) 45 'https://testdrive-archive.azurewebsites.net/performance/chalkboard/', s elf))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698