Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1993763002: Revert of Fix hanging on browser shutdown. (Closed)

Created:
4 years, 7 months ago by Finnur
Modified:
4 years, 7 months ago
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix hanging on browser shutdown. (patchset #1 id:1 of https://codereview.chromium.org/1990453002/ ) Reason for revert: Judging by the CL description I suspect this is causing a shutdown crash on the Linux ChromiumOS Tests (1) bot: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/20129 Reverting to see if that's correct. Original issue's description: > Fix hanging on browser shutdown. > > It seems that |gconf_client_*| API should be called exactly from the main thread > (which is UI thread), for example see https://bugzilla.mozilla.org/show_bug.cgi?id=518244 > > This CL partially reverts CL https://codereview.chromium.org/1640273002 > and makes calls to |gconf_client_*| API at the main thread. > > BUG=486077 > > Committed: https://crrev.com/c7b954b3dd20dfd349de5d33468f405451452051 > Cr-Commit-Position: refs/heads/master@{#394372} TBR=dmazzoni@chromium.org,iceman@yandex-team.ru # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=486077 Committed: https://crrev.com/44fe05658249a69e0a1c769e6d2c0e0cf7de1f1b Cr-Commit-Position: refs/heads/master@{#394395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -43 lines) Patch
M ui/accessibility/platform/atk_util_auralinux.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/atk_util_auralinux.cc View 3 chunks +28 lines, -43 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Finnur
Created Revert of Fix hanging on browser shutdown.
4 years, 7 months ago (2016-05-18 13:00:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993763002/1
4 years, 7 months ago (2016-05-18 13:00:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993763002/1
4 years, 7 months ago (2016-05-18 13:01:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 13:02:11 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/44fe05658249a69e0a1c769e6d2c0e0cf7de1f1b Cr-Commit-Position: refs/heads/master@{#394395}
4 years, 7 months ago (2016-05-18 13:03:54 UTC) #7
Andrey Kraynov
On 2016/05/18 13:03:54, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 7 months ago (2016-05-18 14:48:34 UTC) #8
Finnur
You could try reverting my revert and if the problem doesn't re-surface then you should ...
4 years, 7 months ago (2016-05-18 17:07:16 UTC) #9
Finnur
Also: My sheriff shift is at an end (it's EOD here), so I advise you ...
4 years, 7 months ago (2016-05-18 17:08:55 UTC) #10
Finnur
4 years, 7 months ago (2016-05-18 17:08:55 UTC) #11
Message was sent while issue was closed.
Also: My sheriff shift is at an end (it's EOD here), so I advise you to work
with the sheriffs that are starting their shifts now.

Powered by Google App Engine
This is Rietveld 408576698