Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1640273002: Initialize Linux Aura accessibility on the file thread. (Closed)

Created:
4 years, 10 months ago by k.czech
Modified:
4 years, 10 months ago
Reviewers:
dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize Linux Aura accessibility on the file thread. It's a part of larger task to move the whole initialization on the separate thread. Previous CL introduced some hard to track issues and broke some perf bots. This CL is first part to make sure bots are fine. It moves gconf related initialization on the file thread. BUG=472183, 468989, 468112 Committed: https://crrev.com/2181d88dcd2bbc47b3c56c1e863c2b4b3212ad70 Cr-Commit-Position: refs/heads/master@{#372074}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Style fix up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -45 lines) Patch
M ui/accessibility/platform/atk_util_auralinux.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/accessibility/platform/atk_util_auralinux.cc View 1 3 chunks +92 lines, -45 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
k.czech
4 years, 10 months ago (2016-01-27 15:26:33 UTC) #2
dmazzoni
lgtm Thanks for splitting this up, hope this works... https://codereview.chromium.org/1640273002/diff/1/ui/accessibility/platform/atk_util_auralinux.cc File ui/accessibility/platform/atk_util_auralinux.cc (right): https://codereview.chromium.org/1640273002/diff/1/ui/accessibility/platform/atk_util_auralinux.cc#newcode40 ui/accessibility/platform/atk_util_auralinux.cc:40: ...
4 years, 10 months ago (2016-01-27 16:28:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640273002/20001
4 years, 10 months ago (2016-01-28 10:56:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 11:44:17 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 11:45:09 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2181d88dcd2bbc47b3c56c1e863c2b4b3212ad70
Cr-Commit-Position: refs/heads/master@{#372074}

Powered by Google App Engine
This is Rietveld 408576698