⛲ Add presubmit to prevent SharedPreferences misuse.

Add presubmit to prevent SharedPreferences misuse.

BUG=599284
Committed: https://crrev.com/bdc444ee2eebb0970f239cc6f651c4e794915c37
Cr-Commit-Position: refs/heads/master@{#395881}

[Peter Wen, 2016-05-19 15:35:28]

wnwen@chromium.org changed reviewers:
+ torne@chromium.org

[Peter Wen, 2016-05-19 15:35:29]

⛺

[Torne, 2016-05-19 15:54:40]

LGTM in general but I don't really know how the presubmit works; I assume there
is some magic that already knows how to spot the bad java calls somwehre?

[Peter Wen, 2016-05-19 18:04:29]

wnwen@chromium.org changed reviewers:
+ michaelbai@chromium.org, nyquist@chromium.org, phajdan.jr@chromium.org

[Peter Wen, 2016-05-19 18:04:29]

+phajdan.jr@ for PRESUBMIT.py OWNERS (check java style on commit too).
+michaelbai@ for tools/android OWNERS. 
+nyquist@ for chrome/android OWNERS.

[michaelbai, 2016-05-19 18:11:28]

On 2016/05/19 18:04:29, Peter Wen wrote:
> +phajdan.jr@ for PRESUBMIT.py OWNERS (check java style on commit too).
> +michaelbai@ for tools/android OWNERS. 
> +nyquist@ for chrome/android OWNERS.

sorry, I don't know about checkstyle, you may try yfriedman@

[Peter Wen, 2016-05-19 18:38:26]

wnwen@chromium.org changed reviewers:
+ yfriedman@chromium.org
- michaelbai@chromium.org

[Peter Wen, 2016-05-19 18:38:27]

+yfriedman@ for checkstyles.

[Paweł Hajdan Jr., 2016-05-19 23:04:01]

LGTM

[Yaron, 2016-05-20 14:46:04]

lgtm

https://codereview.chromium.org/1993243002/diff/2/tools/android/checkstyle/su...
File tools/android/checkstyle/suppressions.xml (right):

https://codereview.chromium.org/1993243002/diff/2/tools/android/checkstyle/su...
tools/android/checkstyle/suppressions.xml:4: <suppressions>
Nice that this kind of proves that it works ;)

[nyquist, 2016-05-23 21:19:59]

lgtm

[Peter Wen, 2016-05-24 12:09:42]

Thanks for the reviews!

https://codereview.chromium.org/1993243002/diff/2/tools/android/checkstyle/su...
File tools/android/checkstyle/suppressions.xml (right):

https://codereview.chromium.org/1993243002/diff/2/tools/android/checkstyle/su...
tools/android/checkstyle/suppressions.xml:4: <suppressions>
On 2016/05/20 14:46:04, Yaron wrote:
> Nice that this kind of proves that it works ;)

Yep, took this out and it spits out a presubmit error. :)

[Peter Wen, 2016-05-24 12:12:55]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2016-05-24 12:12:55]

The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org
Link to the patchset: https://codereview.chromium.org/1993243002/#ps2 (title:
"Add suppression for ContextUtils.")

[commit-bot: I haz the power, 2016-05-24 12:13:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1993243002/2
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1993243002/2

[commit-bot: I haz the power, 2016-05-24 12:19:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 12:19:50]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Peter Wen, 2016-05-25 12:56:42]

The CQ bit was checked by wnwen@chromium.org

[commit-bot: I haz the power, 2016-05-25 12:56:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1993243002/2
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1993243002/2

[commit-bot: I haz the power, 2016-05-25 13:44:26]

Committed patchset #4 (id:2)

[commit-bot: I haz the power, 2016-05-25 13:46:02]

Description was changed from

==========
Add presubmit to prevent SharedPreferences misuse.

BUG=599284
==========

to

==========
Add presubmit to prevent SharedPreferences misuse.

BUG=599284

Committed: https://crrev.com/bdc444ee2eebb0970f239cc6f651c4e794915c37
Cr-Commit-Position: refs/heads/master@{#395881}
==========

[commit-bot: I haz the power, 2016-05-25 13:46:03]

Patchset 4 (id:??) landed as
https://crrev.com/bdc444ee2eebb0970f239cc6f651c4e794915c37
Cr-Commit-Position: refs/heads/master@{#395881}