Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: tools/android/checkstyle/suppressions.xml

Issue 1993243002: ⛲ Add presubmit to prevent SharedPreferences misuse. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add suppression for ContextUtils. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/android/checkstyle/chromium-style-5.0.xml ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 <?xml version="1.0" encoding="UTF-8"?>
2 <!DOCTYPE suppressions PUBLIC "-//Puppy Crawl//DTD Suppressions 1.1//EN" "http:/ /www.puppycrawl.com/dtds/suppressions_1_1.dtd">
3
4 <suppressions>
Yaron 2016/05/20 14:46:04 Nice that this kind of proves that it works ;)
Peter Wen 2016/05/24 12:09:42 Yep, took this out and it spits out a presubmit er
5 <suppress id="SharedPreferencesCheck" files="ContextUtils.java"/>
6 </suppressions>
OLDNEW
« no previous file with comments | « tools/android/checkstyle/chromium-style-5.0.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698