Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: tools/android/checkstyle/chromium-style-5.0.xml

Issue 1993243002: ⛲ Add presubmit to prevent SharedPreferences misuse. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add suppression for ContextUtils. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="UTF-8"?> 1 <?xml version="1.0" encoding="UTF-8"?>
2 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http: //www.puppycrawl.com/dtds/configuration_1_3.dtd"> 2 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http: //www.puppycrawl.com/dtds/configuration_1_3.dtd">
3 3
4 <!-- 4 <!--
5 See installation instructions: https://sites.google.com/a/chromium.org/dev/che ckstyle 5 See installation instructions: https://sites.google.com/a/chromium.org/dev/che ckstyle
6 --> 6 -->
7 <module name="Checker"> 7 <module name="Checker">
8 <property name="severity" value="warning"/> 8 <property name="severity" value="warning"/>
9 <property name="charset" value="UTF-8"/> 9 <property name="charset" value="UTF-8"/>
10 <module name="SuppressionFilter">
11 <property name="file" value="tools/android/checkstyle/suppressions.xml"/>
12 </module>
10 <module name="TreeWalker"> 13 <module name="TreeWalker">
11 <module name="AvoidStarImport"> 14 <module name="AvoidStarImport">
12 <property name="severity" value="error"/> 15 <property name="severity" value="error"/>
13 </module> 16 </module>
14 <module name="IllegalCatch"> 17 <module name="IllegalCatch">
15 <property name="severity" value="info"/> 18 <property name="severity" value="info"/>
16 </module> 19 </module>
17 <module name="RedundantImport"> 20 <module name="RedundantImport">
18 <message key="import.redundant" value="Redundant import: {0}. Use :JavaImp ortOrganize (ECLIM) or Ctrl+Shift+O (Eclipse) to sort imports"/> 21 <message key="import.redundant" value="Redundant import: {0}. Use :JavaImp ortOrganize (ECLIM) or Ctrl+Shift+O (Eclipse) to sort imports"/>
19 <property name="severity" value="error"/> 22 <property name="severity" value="error"/>
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 <property name="format" value="StringBuffer"/> 204 <property name="format" value="StringBuffer"/>
202 <property name="ignoreComments" value="true"/> 205 <property name="ignoreComments" value="true"/>
203 <property name="message" value="Avoid StringBuffer; use StringBuilder inst ead, which is faster (it's not thread-safe, but this is almost never needed)"/> 206 <property name="message" value="Avoid StringBuffer; use StringBuilder inst ead, which is faster (it's not thread-safe, but this is almost never needed)"/>
204 </module> 207 </module>
205 <module name="RegexpSinglelineJava"> 208 <module name="RegexpSinglelineJava">
206 <property name="severity" value="warning"/> 209 <property name="severity" value="warning"/>
207 <property name="format" value="android\.app\.AlertDialog"/> 210 <property name="format" value="android\.app\.AlertDialog"/>
208 <property name="ignoreComments" value="true"/> 211 <property name="ignoreComments" value="true"/>
209 <property name="message" value="Avoid android.app.AlertDialog; if possible , use android.support.v7.app.AlertDialog instead, which has a Material look on a ll devices. (Some parts of the codebase can’t depend on the support library, in which case android.app.AlertDialog is the only option)"/> 212 <property name="message" value="Avoid android.app.AlertDialog; if possible , use android.support.v7.app.AlertDialog instead, which has a Material look on a ll devices. (Some parts of the codebase can’t depend on the support library, in which case android.app.AlertDialog is the only option)"/>
210 </module> 213 </module>
214 <module name="RegexpSinglelineJava">
215 <property name="id" value="SharedPreferencesCheck"/>
216 <property name="severity" value="error"/>
217 <property name="format" value="getDefaultSharedPreferences"/>
218 <property name="ignoreComments" value="true"/>
219 <property name="message" value="Use ContextUtils.getAppSharedPreferences() instead to access app-wide SharedPreferences."/>
220 </module>
211 </module> 221 </module>
212 222
213 <!-- Non-TreeWalker modules --> 223 <!-- Non-TreeWalker modules -->
214 <module name="FileTabCharacter"> 224 <module name="FileTabCharacter">
215 <property name="severity" value="error"/> 225 <property name="severity" value="error"/>
216 </module> 226 </module>
217 <module name="RegexpSingleline"> 227 <module name="RegexpSingleline">
218 <property name="severity" value="error"/> 228 <property name="severity" value="error"/>
219 <property name="format" value="[ \t]+$"/> 229 <property name="format" value="[ \t]+$"/>
220 <property name="message" value="Trailing whitespace"/> 230 <property name="message" value="Trailing whitespace"/>
221 </module> 231 </module>
222 <module name="RegexpHeader"> 232 <module name="RegexpHeader">
223 <property name="severity" value="error"/> 233 <property name="severity" value="error"/>
224 <property name="header" value="^// Copyright 20\d\d The Chromium Authors. Al l rights reserved.$\n^// Use of this source code is governed by a BSD-style lice nse that can be$\n^// found in the LICENSE file.$"/> 234 <property name="header" value="^// Copyright 20\d\d The Chromium Authors. Al l rights reserved.$\n^// Use of this source code is governed by a BSD-style lice nse that can be$\n^// found in the LICENSE file.$"/>
225 </module> 235 </module>
226 </module> 236 </module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698