Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1993053002: Simplify ContentHandlerFactory a bit. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Simplify ContentHandlerFactory a bit. On the road to nuking the class itself. Now you don't even need to instantiate it anymore. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/693c3790df4f6dd0c66741bf374424bfd620e3d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -76 lines) Patch
M examples/forwarding_content_handler/forwarding_content_handler.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M examples/recursive_content_handler/recursive_content_handler.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/application/content_handler_factory.h View 2 chunks +4 lines, -15 lines 0 comments Download
M mojo/application/content_handler_factory.cc View 2 chunks +6 lines, -16 lines 0 comments Download
M services/dart/content_handler_main.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M services/java_handler/java_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/java_handler/java_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/js/content_handler_main.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M services/nacl/nonsfi/content_handler_main_nexe.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M services/nacl/nonsfi/content_handler_main_pexe.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M services/nacl/sfi/content_handler_main.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M services/python/content_handler/content_handler_main.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M shell/android/android_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M shell/android/android_handler.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-18 22:42:41 UTC) #1
viettrungluu
ping
4 years, 7 months ago (2016-05-19 17:56:14 UTC) #2
vardhan
lgtm
4 years, 7 months ago (2016-05-19 20:20:21 UTC) #3
viettrungluu
4 years, 7 months ago (2016-05-19 20:31:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
693c3790df4f6dd0c66741bf374424bfd620e3d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698