Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: mojo/application/content_handler_factory.h

Issue 1993053002: Simplify ContentHandlerFactory a bit. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/application/content_handler_factory.h
diff --git a/mojo/application/content_handler_factory.h b/mojo/application/content_handler_factory.h
index 86293dfe4c73ea3bd7d346b9b4b41f60e34caaee..b1ebccccb493e24d60335ebbdd91c8888e040a97 100644
--- a/mojo/application/content_handler_factory.h
+++ b/mojo/application/content_handler_factory.h
@@ -15,7 +15,8 @@ namespace mojo {
struct ConnectionContext;
-// TODO(vtl): Should this even be a class, now that InterfaceFactory is no more?
+// TODO(vtl): Nuke this class. Now it's only a "namespace" for stuff, most of
+// which is overcomplicated.
class ContentHandlerFactory {
public:
class HandledApplicationHolder {
@@ -49,21 +50,9 @@ class ContentHandlerFactory {
URLResponsePtr response) override;
};
- explicit ContentHandlerFactory(Delegate* delegate);
- ~ContentHandlerFactory();
-
- // Creates a content handler for the given connection (context and request).
- void Create(const ConnectionContext& connection_context,
- InterfaceRequest<ContentHandler> content_handler_request);
-
// For use with |ServiceProviderImpl::AddService<ContentHandler>()|.
- ServiceProviderImpl::InterfaceRequestHandler<ContentHandler>
- GetInterfaceRequestHandler();
-
- private:
- Delegate* delegate_;
-
- DISALLOW_COPY_AND_ASSIGN(ContentHandlerFactory);
+ static ServiceProviderImpl::InterfaceRequestHandler<ContentHandler>
+ GetInterfaceRequestHandler(Delegate* delegate);
};
template <class A>
« no previous file with comments | « examples/recursive_content_handler/recursive_content_handler.cc ('k') | mojo/application/content_handler_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698