Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: services/js/content_handler_main.cc

Issue 1993053002: Simplify ContentHandlerFactory a bit. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/i18n/icu_util.h" 5 #include "base/i18n/icu_util.h"
6 #include "gin/array_buffer.h" 6 #include "gin/array_buffer.h"
7 #include "gin/public/isolate_holder.h" 7 #include "gin/public/isolate_holder.h"
8 #include "mojo/application/application_runner_chromium.h" 8 #include "mojo/application/application_runner_chromium.h"
9 #include "mojo/application/content_handler_factory.h" 9 #include "mojo/application/content_handler_factory.h"
10 #include "mojo/public/c/system/main.h" 10 #include "mojo/public/c/system/main.h"
11 #include "mojo/public/cpp/application/application_delegate.h" 11 #include "mojo/public/cpp/application/application_delegate.h"
12 #include "mojo/public/cpp/application/application_impl.h" 12 #include "mojo/public/cpp/application/application_impl.h"
13 #include "services/js/js_app.h" 13 #include "services/js/js_app.h"
14 14
15 namespace js { 15 namespace js {
16 16
17 class JsContentHandler : public mojo::ApplicationDelegate, 17 class JsContentHandler : public mojo::ApplicationDelegate,
18 public mojo::ContentHandlerFactory::ManagedDelegate { 18 public mojo::ContentHandlerFactory::ManagedDelegate {
19 public: 19 public:
20 JsContentHandler() : content_handler_factory_(this) {} 20 JsContentHandler() {}
21 21
22 private: 22 private:
23 // Overridden from mojo::ApplicationDelegate: 23 // Overridden from mojo::ApplicationDelegate:
24 void Initialize(mojo::ApplicationImpl* app) override { 24 void Initialize(mojo::ApplicationImpl* app) override {
25 static const char v8Flags[] = "--harmony-classes"; 25 static const char v8Flags[] = "--harmony-classes";
26 v8::V8::SetFlagsFromString(v8Flags, sizeof(v8Flags) - 1); 26 v8::V8::SetFlagsFromString(v8Flags, sizeof(v8Flags) - 1);
27 base::i18n::InitializeICU(); 27 base::i18n::InitializeICU();
28 gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode, 28 gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode,
29 gin::ArrayBufferAllocator::SharedInstance()); 29 gin::ArrayBufferAllocator::SharedInstance());
30 } 30 }
31 31
32 // Overridden from ApplicationDelegate: 32 // Overridden from ApplicationDelegate:
33 bool ConfigureIncomingConnection( 33 bool ConfigureIncomingConnection(
34 mojo::ServiceProviderImpl* service_provider_impl) override { 34 mojo::ServiceProviderImpl* service_provider_impl) override {
35 service_provider_impl->AddService<mojo::ContentHandler>( 35 service_provider_impl->AddService<mojo::ContentHandler>(
36 content_handler_factory_.GetInterfaceRequestHandler()); 36 mojo::ContentHandlerFactory::GetInterfaceRequestHandler(this));
37 return true; 37 return true;
38 } 38 }
39 39
40 // Overridden from ContentHandlerFactory::ManagedDelegate: 40 // Overridden from ContentHandlerFactory::ManagedDelegate:
41 scoped_ptr<mojo::ContentHandlerFactory::HandledApplicationHolder> 41 scoped_ptr<mojo::ContentHandlerFactory::HandledApplicationHolder>
42 CreateApplication( 42 CreateApplication(
43 mojo::InterfaceRequest<mojo::Application> application_request, 43 mojo::InterfaceRequest<mojo::Application> application_request,
44 mojo::URLResponsePtr response) override { 44 mojo::URLResponsePtr response) override {
45 return make_scoped_ptr( 45 return make_scoped_ptr(
46 new JSApp(application_request.Pass(), response.Pass())); 46 new JSApp(application_request.Pass(), response.Pass()));
47 } 47 }
48 48
49 mojo::ContentHandlerFactory content_handler_factory_;
50
51 DISALLOW_COPY_AND_ASSIGN(JsContentHandler); 49 DISALLOW_COPY_AND_ASSIGN(JsContentHandler);
52 }; 50 };
53 51
54 } // namespace js 52 } // namespace js
55 53
56 MojoResult MojoMain(MojoHandle application_request) { 54 MojoResult MojoMain(MojoHandle application_request) {
57 mojo::ApplicationRunnerChromium runner(new js::JsContentHandler); 55 mojo::ApplicationRunnerChromium runner(new js::JsContentHandler);
58 return runner.Run(application_request); 56 return runner.Run(application_request);
59 } 57 }
OLDNEW
« no previous file with comments | « services/java_handler/java_handler.cc ('k') | services/nacl/nonsfi/content_handler_main_nexe.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698