Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1992913004: [heap] Do not invoke GC to make heap iterable. (Closed)

Created:
4 years, 7 months ago by Hannes Payer (out of office)
Modified:
4 years, 6 months ago
Reviewers:
ulan, Yang
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Do not invoke GC to make heap iterable. This reverts commit 0aa3707dc403a5285d216b01d24faa27375ceec4. And removes the UnreachableObjectsFilter. BUG=chromium:580959 LOG=n Committed: https://crrev.com/132f89800f560190b4d655adcb4e0eeedd17fd82 Cr-Commit-Position: refs/heads/master@{#36617}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -177 lines) Patch
M src/api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/heap.h View 1 6 chunks +6 lines, -28 lines 0 comments Download
M src/heap/heap.cc View 1 4 chunks +12 lines, -109 lines 0 comments Download
M src/log.cc View 1 3 chunks +3 lines, -8 lines 0 comments Download
M src/profiler/heap-profiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/profiler/heap-snapshot-generator.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 5 chunks +15 lines, -15 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-log.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/debug-referenced-by.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Yang
lgtm
4 years, 6 months ago (2016-05-30 11:22:55 UTC) #2
ulan
lgtm
4 years, 6 months ago (2016-05-30 11:35:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992913004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992913004/40001
4 years, 6 months ago (2016-05-31 14:09:17 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-31 14:48:14 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/132f89800f560190b4d655adcb4e0eeedd17fd82 Cr-Commit-Position: refs/heads/master@{#36617}
4 years, 6 months ago (2016-05-31 14:50:46 UTC) #10
Michael Achenbach
There are a bunch of flakes on the waterfall like this one: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20-%20debug/builds/7409/steps/Check%20%28flakes%29/logs/WeakGlobalHandle is this ...
4 years, 6 months ago (2016-05-31 17:31:25 UTC) #11
Michael Achenbach
4 years, 6 months ago (2016-05-31 17:40:10 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2020363002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative revert for some flakes on the
waterfall:
https://build.chromium.org/p/client.v8/builders/V8%20Mac%20-%20debug/builds/7409
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20avx2/build...
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20internal%2....

Powered by Google App Engine
This is Rietveld 408576698