test/cctest/test-heap-profiler.cc - Issue 1992913004: [heap] Do not invoke GC to make heap iterable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 1992913004: [heap] Do not invoke GC to make heap iterable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-heap-profiler.cc

diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc

index 767c5cd4b4670d3231400ca268c5261eef401809..86cd8b1e3e07395142da70809b66874a6ecd8fce 100644

--- a/test/cctest/test-heap-profiler.cc

+++ b/test/cctest/test-heap-profiler.cc

@@ -705,7 +705,6 @@ TEST(HeapSnapshotAddressReuse) {

CcTest::heap()->CollectAllGarbage();

const v8::HeapSnapshot* snapshot2 = heap_profiler->TakeHeapSnapshot();

- CHECK(ValidateSnapshot(snapshot2));

const v8::HeapGraphNode* global2 = GetGlobalObject(snapshot2);

const v8::HeapGraphNode* array_node =

« no previous file with comments | « test/cctest/test-debug.cc ('k') | test/cctest/test-log.cc » ('j') | no next file with comments »