test/cctest/test-log.cc - Issue 1992913004: [heap] Do not invoke GC to make heap iterable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-log.cc

Issue 1992913004: [heap] Do not invoke GC to make heap iterable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-log.cc

diff --git a/test/cctest/test-log.cc b/test/cctest/test-log.cc

index c3856f2c43f968edcedc82583023eff3ce59f36e..f5806c411817238fd35a9c1b51a590c51cc93386 100644

--- a/test/cctest/test-log.cc

+++ b/test/cctest/test-log.cc

@@ -485,8 +485,6 @@ TEST(EquivalenceOfLoggingAndTraversal) {

" (function a(j) { return function b() { return j; } })(100);\n"

"})(this);");

logger->StopProfiler();

- reinterpret_cast<i::Isolate*>(isolate)->heap()->CollectAllGarbage(

- i::Heap::kMakeHeapIterableMask);

logger->StringEvent("test-logging-done", "");

// Iterate heap to find compiled functions, will write to log.

« no previous file with comments | « test/cctest/test-heap-profiler.cc ('k') | test/mjsunit/debug-referenced-by.js » ('j') | no next file with comments »