Remove ash::switches::UseImmersiveFullscreenForAllWindows()

Remove ash::switches::UseImmersiveFullscreenForAllWindows(). We are not considering turning the feature off. Remove its flag and get rid of some code complexity

BUG=None
TEST=None
R=oshima
TBR=jamescook, benwells for trivial removal of checking ash::switches::UseImmersiveFullscreenForAllWindows()

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256952

[pkotwicz, 2014-03-13 16:43:15]

Oshima, PTAL

https://codereview.chromium.org/199283002/diff/1/ash/wm/window_state.cc
File ash/wm/window_state.cc (left):

https://codereview.chromium.org/199283002/diff/1/ash/wm/window_state.cc#oldco...
ash/wm/window_state.cc:99: #if defined(OS_CHROMEOS)
zturner@ is enabling immersive fullscreen on Windows Ash too. So I think it is
safe to kill |animate_to_fullscreen_|.

[oshima, 2014-03-13 17:05:09]

nice! lgtm

[pkotwicz, 2014-03-13 18:19:36]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-03-13 18:22:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/199283002/1

[commit-bot: I haz the power, 2014-03-13 18:22:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 18:22:50]

Failed to apply patch for ash/ash_switches.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ash/ash_switches.cc
  Hunk #1 succeeded at 61 (offset -9 lines).
  Hunk #2 FAILED at 137.
  1 out of 2 hunks FAILED -- saving rejects to file ash/ash_switches.cc.rej

Patch:       ash/ash_switches.cc
Index: ash/ash_switches.cc
diff --git a/ash/ash_switches.cc b/ash/ash_switches.cc
index
6bd34cb72a04501a783d5e21619ef9a188ed4aed..8cddb55d247ecedf2612d9628c28bac995772d56
100644
--- a/ash/ash_switches.cc
+++ b/ash/ash_switches.cc
@@ -70,15 +70,6 @@ const char kAshEnableAlternateFrameCaptionButtonStyle[] =
 // main monitor as internal.
 const char kAshEnableBrightnessControl[] = "ash-enable-brightness-control";
 
-// Enables putting all windows into immersive fullscreen via <F4>.
-const char kAshEnableImmersiveFullscreenForAllWindows[] =
-    "ash-enable-immersive-all-windows";
-
-// Enables putting only browser windows into immersive fullscreen via <F4>.
-// <F4> puts all other windows into non-immersive fullscreen.
-const char kAshEnableImmersiveFullscreenForBrowserOnly[] =
-    "ash-enable-immersive-browser-only";
-
 #if defined(OS_CHROMEOS)
 // Enables key bindings to scroll magnified screen.
 const char kAshEnableMagnifierKeyScroller[] =
@@ -146,11 +137,6 @@ bool UseAlternateFrameCaptionButtonStyle() {
       HasSwitch(kAshDisableAlternateFrameCaptionButtonStyle);
 }
 
-bool UseImmersiveFullscreenForAllWindows() {
-  return !CommandLine::ForCurrentProcess()->HasSwitch(
-      kAshEnableImmersiveFullscreenForBrowserOnly);
-}
-
 bool UseOverviewMode() {
   return !CommandLine::ForCurrentProcess()->HasSwitch(kAshDisableOverviewMode);
 }

[pkotwicz, 2014-03-13 20:26:23]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-03-13 20:29:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/199283002/20001

[commit-bot: I haz the power, 2014-03-13 23:57:04]

Change committed as 256952