Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1992663003: [DevTools] Capture call stacks for svg parser console messages. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
kozy, pfeldman
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, krit, f(malita), darktears, blink-reviews, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Capture call stacks for svg parser console messages. We collect call stacks synchronously a bit later in ConsoleMessageStorage::reportMessage, so there is no performance penalty. BUG=611926 Committed: https://crrev.com/8619d40f39c2e182d1042db6aa24a4dc95d388f1 Cr-Commit-Position: refs/heads/master@{#394702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16907 lines, -16905 lines) Patch
M third_party/WebKit/LayoutTests/fast/svg/whitespace-angle-expected.txt View 1 chunk +1824 lines, -1824 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/svg/whitespace-integer-expected.txt View 1 chunk +605 lines, -605 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/svg/whitespace-length-expected.txt View 1 chunk +392 lines, -392 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/svg/whitespace-number-expected.txt View 1 chunk +1108 lines, -1108 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/fast/svg/whitespace-angle-expected.txt View 1 chunk +1824 lines, -1824 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/fast/svg/whitespace-integer-expected.txt View 1 chunk +605 lines, -605 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/fast/svg/whitespace-length-expected.txt View 1 chunk +392 lines, -392 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/svg/css/parse-length-expected.txt View 1 chunk +80 lines, -80 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/svg/custom/animation-values-parsing-error-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/svg/custom/disallow-non-lengths-in-attrs-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/svg/custom/invalid-length-units-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/svg/custom/invalid-transforms-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/svg/custom/keySplines-parsing-error-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/svg/custom/keyTimes-parsing-error-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/svg/custom/poly-parsing-error-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/svg/custom/polyline-setattribute-points-null-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/svg/dom/points-parser-expected.txt View 1 chunk +11 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/svg/dom/preserve-aspect-ratio-parser-expected.txt View 1 chunk +36 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/svg/dom/transform-parser-expected.txt View 1 chunk +921 lines, -921 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/svg/parser/whitespace-length-invalid-1-expected.txt View 1 chunk +1500 lines, -1500 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/svg/parser/whitespace-length-invalid-2-expected.txt View 1 chunk +2500 lines, -2500 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/parse-length-expected.txt View 1 chunk +80 lines, -80 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/animation-values-parsing-error-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/disallow-non-lengths-in-attrs-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/invalid-length-units-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/invalid-transforms-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/keySplines-parsing-error-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/keyTimes-parsing-error-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/poly-parsing-error-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/polyline-setattribute-points-null-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/points-parser-expected.txt View 1 chunk +11 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/preserve-aspect-ratio-parser-expected.txt View 1 chunk +36 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/transform-parser-expected.txt View 1 chunk +921 lines, -921 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-1-expected.txt View 1 chunk +1500 lines, -1500 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-2-expected.txt View 1 chunk +2500 lines, -2500 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992663003/1
4 years, 7 months ago (2016-05-18 23:16:31 UTC) #2
dgozman
Take a look please.
4 years, 7 months ago (2016-05-19 02:22:02 UTC) #5
kozy
lgtm
4 years, 7 months ago (2016-05-19 06:51:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992663003/1
4 years, 7 months ago (2016-05-19 06:52:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 06:57:07 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8619d40f39c2e182d1042db6aa24a4dc95d388f1 Cr-Commit-Position: refs/heads/master@{#394702}
4 years, 7 months ago (2016-05-19 06:59:54 UTC) #11
pfeldman
>> We collect call stacks synchronously a bit later in ConsoleMessageStorage::reportMessage, so there is no ...
4 years, 7 months ago (2016-05-19 07:06:07 UTC) #12
dgozman
4 years, 7 months ago (2016-05-19 07:16:25 UTC) #13
Message was sent while issue was closed.
On 2016/05/19 07:06:07, pfeldman wrote:
> >> We collect call stacks synchronously a bit later in
> ConsoleMessageStorage::reportMessage, so there is no performance penalty.
> 
> if we do it synchronously, why isn't the stack the same?

It is the same. We just didn't report it to ChromeClient before to avoid all
test rebaselines. After a couple of patches terminal output will be the same as
devtools console.
Current situation blocks me from moving console into v8_inspector.

Powered by Google App Engine
This is Rietveld 408576698