third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp - Issue 1992663003: [DevTools] Capture call stacks for svg parser console messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp

Issue 1992663003: [DevTools] Capture call stacks for svg parser console messages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp b/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp

index 8939f49f36468e79e3357ca434d6dff24a42d7ac..ae734611dbda8c507c0c04ad3eb0ae13e3c45c8e 100644

--- a/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp

@@ -150,7 +150,9 @@ void SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements()

void SVGDocumentExtensions::reportError(const String& message)

{

- m_document->addConsoleMessage(ConsoleMessage::create(RenderingMessageSource, ErrorMessageLevel, "Error: " + message));

+ ConsoleMessage* consoleMessage = ConsoleMessage::create(RenderingMessageSource, ErrorMessageLevel, "Error: " + message);

+ consoleMessage->collectCallStack();

+ m_document->addConsoleMessage(consoleMessage);

}

void SVGDocumentExtensions::addPendingResource(const AtomicString& id, Element* element)

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-2-expected.txt ('k') | no next file » | no next file with comments »