Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp

Issue 1992663003: [DevTools] Capture call stacks for svg parser console messages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-2-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Inc. All rights reserved. 2 * Copyright (C) 2006 Apple Inc. All rights reserved.
3 * Copyright (C) 2006 Nikolas Zimmermann <zimmermann@kde.org> 3 * Copyright (C) 2006 Nikolas Zimmermann <zimmermann@kde.org>
4 * Copyright (C) 2007 Rob Buis <buis@kde.org> 4 * Copyright (C) 2007 Rob Buis <buis@kde.org>
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 continue; 143 continue;
144 144
145 // don't dispatch the load event document is not wellformed (for XML/sta ndalone svg) 145 // don't dispatch the load event document is not wellformed (for XML/sta ndalone svg)
146 if (outerSVG->document().wellFormed() || !outerSVG->document().isSVGDocu ment()) 146 if (outerSVG->document().wellFormed() || !outerSVG->document().isSVGDocu ment())
147 outerSVG->sendSVGLoadEventIfPossible(); 147 outerSVG->sendSVGLoadEventIfPossible();
148 } 148 }
149 } 149 }
150 150
151 void SVGDocumentExtensions::reportError(const String& message) 151 void SVGDocumentExtensions::reportError(const String& message)
152 { 152 {
153 m_document->addConsoleMessage(ConsoleMessage::create(RenderingMessageSource, ErrorMessageLevel, "Error: " + message)); 153 ConsoleMessage* consoleMessage = ConsoleMessage::create(RenderingMessageSour ce, ErrorMessageLevel, "Error: " + message);
154 consoleMessage->collectCallStack();
155 m_document->addConsoleMessage(consoleMessage);
154 } 156 }
155 157
156 void SVGDocumentExtensions::addPendingResource(const AtomicString& id, Element* element) 158 void SVGDocumentExtensions::addPendingResource(const AtomicString& id, Element* element)
157 { 159 {
158 ASSERT(element); 160 ASSERT(element);
159 ASSERT(element->inShadowIncludingDocument()); 161 ASSERT(element->inShadowIncludingDocument());
160 162
161 if (id.isEmpty()) 163 if (id.isEmpty())
162 return; 164 return;
163 165
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 { 362 {
361 visitor->trace(m_document); 363 visitor->trace(m_document);
362 visitor->trace(m_timeContainers); 364 visitor->trace(m_timeContainers);
363 visitor->trace(m_webAnimationsPendingSVGElements); 365 visitor->trace(m_webAnimationsPendingSVGElements);
364 visitor->trace(m_relativeLengthSVGRoots); 366 visitor->trace(m_relativeLengthSVGRoots);
365 visitor->trace(m_pendingResources); 367 visitor->trace(m_pendingResources);
366 visitor->trace(m_pendingResourcesForRemoval); 368 visitor->trace(m_pendingResourcesForRemoval);
367 } 369 }
368 370
369 } // namespace blink 371 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-2-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698