Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1992633003: Add "Sign In" button to the account chooser on Mac. (Closed)

Created:
4 years, 7 months ago by vasilii
Modified:
4 years, 7 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, asvitkine+watch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add "Sign In" button to the account chooser on Mac. BUG=612501 Committed: https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108 Cr-Commit-Position: refs/heads/master@{#394744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -63 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm View 6 chunks +35 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm View 5 chunks +14 lines, -19 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller.mm View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller_unittest.mm View 2 chunks +1 line, -19 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.mm View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/passwords/password_dialog_controller.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/passwords/password_dialog_controller_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/passwords/password_dialog_controller_impl.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc View 4 chunks +33 lines, -1 line 0 comments Download
A chrome/browser/ui/passwords/password_dialog_controller_mock.h View 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/browser/ui/passwords/password_dialog_controller_mock.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +6 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_manager_metrics_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
vasilii
Hi guys, please review: Ilya: histograms.xml Scott: BUILD.gn Rachel: all
4 years, 7 months ago (2016-05-18 16:52:44 UTC) #4
groby-ooo-7-16
On 2016/05/18 16:52:44, vasilii wrote: > Hi guys, > > please review: > > Ilya: ...
4 years, 7 months ago (2016-05-18 17:45:03 UTC) #5
sky
BUILD.gn LGTM
4 years, 7 months ago (2016-05-18 19:29:18 UTC) #6
Ilya Sherman
histograms.xml lgtm
4 years, 7 months ago (2016-05-18 21:05:53 UTC) #7
vasilii
Hi Vadym, please review the CL.
4 years, 7 months ago (2016-05-19 08:33:03 UTC) #8
vasilii
PTAL
4 years, 7 months ago (2016-05-19 08:33:47 UTC) #10
dvadym
On 2016/05/19 08:33:47, vasilii wrote: > PTAL LGTM
4 years, 7 months ago (2016-05-19 09:54:57 UTC) #11
dvadym
On 2016/05/19 08:33:47, vasilii wrote: > PTAL LGTM
4 years, 7 months ago (2016-05-19 09:55:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992633003/1
4 years, 7 months ago (2016-05-19 11:38:14 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 12:05:21 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 12:06:39 UTC) #18
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d69c3927d11b6fccbbecd34632b8f2ed34e19108
Cr-Commit-Position: refs/heads/master@{#394744}

Powered by Google App Engine
This is Rietveld 408576698