Add "Sign In" button to the account chooser on Mac.

chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.h"
 
 #include <utility>
 
 #include <Carbon/Carbon.h>
 
 #include "base/mac/foundation_util.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/strings/string16.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/cocoa/cocoa_test_helper.h"
 #import "chrome/browser/ui/cocoa/passwords/account_avatar_fetcher_manager.h"
 #import "chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.h"
 #import "chrome/browser/ui/cocoa/passwords/credential_item_button.h"
-#include "chrome/browser/ui/passwords/password_dialog_controller.h"
+#include "chrome/browser/ui/passwords/password_dialog_controller_mock.h"
 #include "components/autofill/core/common/password_form.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/gtest_mac.h"
 #import "ui/events/test/cocoa_test_event_utils.h"
 #include "url/gurl.h"
 #include "url/origin.h"
 
 @interface AccountAvatarFetcherTestManager : AccountAvatarFetcherManager {
   std::vector<GURL> fetchedAvatars_;
@@ skipping 18 matching lines @@
 constexpr char kDialogTitle[] = "Choose an account";
 
 // Returns a PasswordForm with only a username.
 std::unique_ptr<autofill::PasswordForm> Credential(const char* username) {
   std::unique_ptr<autofill::PasswordForm> credential(
       new autofill::PasswordForm);
   credential->username_value = base::ASCIIToUTF16(username);
   return credential;
 }
 
-class PasswordDialogControllerMock : public PasswordDialogController {
- public:
-  MOCK_CONST_METHOD0(GetLocalForms, const FormsVector&());
-  MOCK_CONST_METHOD0(GetFederationsForms, const FormsVector&());
-  MOCK_CONST_METHOD0(GetAccoutChooserTitle,
-                     std::pair<base::string16, gfx::Range>());
-  MOCK_CONST_METHOD0(GetAutoSigninPromoTitle, base::string16());
-  MOCK_CONST_METHOD0(GetAutoSigninText,
-                     std::pair<base::string16, gfx::Range>());
-  MOCK_METHOD0(OnSmartLockLinkClicked, void());
-  MOCK_METHOD2(OnChooseCredentials, void(
-      const autofill::PasswordForm& password_form,
-      password_manager::CredentialType credential_type));
-  MOCK_METHOD0(OnAutoSigninOK, void());
-  MOCK_METHOD0(OnAutoSigninTurnOff, void());
-  MOCK_METHOD0(OnCloseDialog, void());
-};
-
 // Tests for the account chooser dialog view.
 class AccountChooserViewControllerTest : public CocoaTest,
                                          public PasswordPromptBridgeInterface {
  public:
   void SetUp() override;
 
   PasswordDialogControllerMock& dialog_controller() {
     return dialog_controller_;
   }
 
@@ skipping 28 matching lines @@
 void AccountChooserViewControllerTest::SetUpAccountChooser(
     PasswordDialogController::FormsVector* local) {
   view_controller_.reset([[AccountChooserViewController alloc]
       initWithBridge:this
       avatarManager:avatar_manager()]);
   EXPECT_CALL(dialog_controller_, GetLocalForms())
       .WillOnce(testing::ReturnRef(*local));
   EXPECT_CALL(dialog_controller_, GetAccoutChooserTitle())
       .WillOnce(testing::Return(std::make_pair(base::ASCIIToUTF16(kDialogTitle),
                                                gfx::Range(0, 5))));
+  EXPECT_CALL(dialog_controller_, ShouldShowSignInButton())
+      .WillOnce(testing::Return(local->size() == 1));
   [view_controller_ view];
   ASSERT_TRUE(testing::Mock::VerifyAndClearExpectations(&dialog_controller_));
 }
 
 void AccountChooserViewControllerTest::PerformClose() {
   view_controller_.reset();
   OnPerformClose();
 }
 
 PasswordDialogController*
@@ skipping 79 matching lines @@
 
 TEST_F(AccountChooserViewControllerTest, ClickTitleLink) {
   PasswordDialogController::FormsVector local_forms;
   local_forms.push_back(Credential("pizza"));
   SetUpAccountChooser(&local_forms);
   EXPECT_CALL(dialog_controller(), OnSmartLockLinkClicked());
   [view_controller().titleView clickedOnLink:@""
                                      atIndex:0];
 }
 
+TEST_F(AccountChooserViewControllerTest, ClickSignIn) {
+  PasswordDialogController::FormsVector local_forms;
+  local_forms.push_back(Credential("pizza"));
+  SetUpAccountChooser(&local_forms);
+  EXPECT_TRUE(view_controller().signInButton);
+  EXPECT_CALL(dialog_controller(), OnSignInClicked());
+  [view_controller().signInButton performClick:nil];
+}
+
 TEST_F(AccountChooserViewControllerTest, ClosePromptAndHandleClick) {
   // A user may press mouse down, some navigation closes the dialog, mouse up
   // still sends the action. The view should not crash.
   PasswordDialogController::FormsVector local_forms;
   local_forms.push_back(Credential("pizza"));
   SetUpAccountChooser(&local_forms);
   [view_controller() setBridge:nil];
   [view_controller().titleView clickedOnLink:@"" atIndex:0];
   [base::mac::ObjCCastStrict<CredentialItemButton>(
       [view_controller().credentialButtons objectAtIndex:0]) performClick:nil];
   [view_controller().cancelButton performClick:nil];
+  EXPECT_TRUE(view_controller().signInButton);
+  [view_controller().signInButton performClick:nil];
 }
 
 TEST_F(AccountChooserViewControllerTest, CloseOnEsc) {
   PasswordDialogController::FormsVector local_forms;
   local_forms.push_back(Credential("pizza"));
   SetUpAccountChooser(&local_forms);
   EXPECT_CALL(*this, OnPerformClose());
   [[view_controller() view]
       performKeyEquivalent:cocoa_test_event_utils::KeyEventWithKeyCode(
                                kVK_Escape, '\e', NSKeyDown, 0)];
 }
 
 }  // namespace