chrome/browser/ui/passwords/password_dialog_controller_impl.h - Issue 1992633003: Add "Sign In" button to the account chooser on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/password_dialog_controller_impl.h

Issue 1992633003: Add "Sign In" button to the account chooser on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/password_dialog_controller.h ('k') | chrome/browser/ui/passwords/password_dialog_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/password_dialog_controller_impl.h

diff --git a/chrome/browser/ui/passwords/password_dialog_controller_impl.h b/chrome/browser/ui/passwords/password_dialog_controller_impl.h

index b1923e286e589b8ca6a1fcb1611635d632b09140..e05ca89fee236079179581614431eb1c70b0f2d0 100644

--- a/chrome/browser/ui/passwords/password_dialog_controller_impl.h

+++ b/chrome/browser/ui/passwords/password_dialog_controller_impl.h

@@ -37,12 +37,14 @@ class PasswordDialogControllerImpl : public PasswordDialogController {

const FormsVector& GetLocalForms() const override;

const FormsVector& GetFederationsForms() const override;

std::pair<base::string16, gfx::Range> GetAccoutChooserTitle() const override;

+ bool ShouldShowSignInButton() const override;

base::string16 GetAutoSigninPromoTitle() const override;

std::pair<base::string16, gfx::Range> GetAutoSigninText() const override;

void OnSmartLockLinkClicked() override;

void OnChooseCredentials(

const autofill::PasswordForm& password_form,

password_manager::CredentialType credential_type) override;

+ void OnSignInClicked() override;

void OnAutoSigninOK() override;

void OnAutoSigninTurnOff() override;

void OnCloseDialog() override;